-
-
Notifications
You must be signed in to change notification settings - Fork 22
Standardize bus handling and add unknown FIP acceptance status #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lenderom
wants to merge
9
commits into
main
Choose a base branch
from
feature/bus-standardization-and-unknown-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
54f1d3d
Standardize bus categories and add unknown FIP acceptance tag
lenderom 2f815da
fix: consistent break of journeys
lenderom ea2770b
fix: update bus reservations
lenderom d80cdab
fix: incorporate feedback
lenderom 3891c14
Merge branch 'main' into feature/bus-standardization-and-unknown-tag
lenderom 31165e0
Merge branch 'main' into feature/bus-standardization-and-unknown-tag
lenderom d7a9d95
fix: fix comma placement
therobrob c472517
Merge remote-tracking branch 'origin/feature/bus-standardization-and-…
therobrob a768a2c
fix: Update "Break of Journey" for VY and ZPCG
MoritzWeber0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
content/generalinformation/faq/does-fip-also-apply-on-buses/_index.de.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Gilt FIP auch in Bussen?" | ||
| weight: 18 | ||
| --- | ||
|
|
||
| Grundsätzlich gilt FIP primär in Zügen. Es gibt aber Betreiber, bei denen FIP auch in Bussen oder sogar auf Schiffen gilt. Weitere Informationen dazu gibt es auf der jeweiligen [Betreiberseite](/operator). |
6 changes: 6 additions & 0 deletions
6
content/generalinformation/faq/does-fip-also-apply-on-buses/_index.en.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Does FIP also apply on buses?" | ||
| weight: 18 | ||
| --- | ||
|
|
||
| In principle, FIP primarily applies on trains. However, there are operators where FIP also applies on buses or even ships. Further information is available on the respective [operator page](/operator). |
6 changes: 6 additions & 0 deletions
6
content/generalinformation/faq/does-fip-also-apply-on-buses/_index.fr.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Le FIP s’applique-t-il également dans les bus ?" | ||
| weight: 18 | ||
| --- | ||
|
|
||
| En principe, le FIP s’applique principalement dans les trains. Il existe cependant des opérateurs pour lesquels le FIP s’applique aussi dans les bus, voire sur des navires. Vous trouverez plus d’informations à ce sujet sur la [page de l’opérateur](/operator). |
6 changes: 6 additions & 0 deletions
6
...t/generalinformation/faq/is-fip-valid-on-rail-replacement-services/_index.de.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Gilt FIP im Schienenersatzverkehr?" | ||
| weight: 17 | ||
| --- | ||
|
|
||
| Ja, FIP Freifahrtscheine und FIP 50 Tickets gelten in der Regel in Schienenersatzverkehrsbussen, wenn sie einen Zug ersetzen, in dem FIP gültig gewesen wäre. Es kann Ausnahmen pro Betreiber geben, siehe [Betreiberseiten](/operator). |
6 changes: 6 additions & 0 deletions
6
...t/generalinformation/faq/is-fip-valid-on-rail-replacement-services/_index.en.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Is FIP valid on rail replacement services?" | ||
| weight: 17 | ||
| --- | ||
|
|
||
| Yes, FIP Coupons and FIP 50 Tickets are generally valid on rail replacement buses if they replace a train on which FIP would have been valid. There may be exceptions per operator, see [operator pages](/operator). |
6 changes: 6 additions & 0 deletions
6
...t/generalinformation/faq/is-fip-valid-on-rail-replacement-services/_index.fr.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: "Le FIP est-il valable dans les services de substitution ferroviaire ?" | ||
| weight: 17 | ||
| --- | ||
|
|
||
| Oui, les Coupons FIP et les Billets FIP 50 sont en règle générale valables dans les bus de substitution ferroviaire, s’ils remplacent un train dans lequel le FIP aurait été valable. Il peut y avoir des exceptions selon l’opérateur, voir les [pages des opérateurs](/operator). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das verwirrt mich: FIP Vergünstigungen gelten nicht im Bus, warum steht bei CD-Ticketschalter nicht "(kein FIP verfügbar)"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja das ist irgendwie doof geschrieben. Was wir sagen wollen:
FIP gilt nicht in Bussen der CD außer SEV und diesem Airport Bus (Reservierungspflicht).
Tickets müssen für diesen Bus vorher gekauft werden. Tickets gibt online, am Schalter und Fahrkartenautomat. FIP Rabatt gibt es aber nur über den Schalter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finde die Formulierung auch verwirrend, mein Vorschlag wäre:
Ein Ticket (Reservierung verpflichtend) muss spätestens 15 Minuten vor Abfahrt an einem ČD Ticketschalter gekauft werden. FIP ermäßigte Tickets sind leider nicht an Fahrkartenautomaten oder im ČD-eShop erhältlich.