fix(firebase_ui_auth): Avoid redundant confirmation on account deletion#494
fix(firebase_ui_auth): Avoid redundant confirmation on account deletion#494russellwheatley merged 3 commits intofirebase:mainfrom EArminjon:fix-avoid-redundant-confirmation-on-account-deletion
Conversation
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Get ou bot |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Get out bot @russellwheatley please take a look :) |
…-account-deletion
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Get away bot |
|
Ty a lot |
Description
When user try to delete his account, when the exception 'requires-recent-login' appear, user need to login again and click again on the modal to confirm the account deletion. That's redundant.
Related Issues
This PR can also bring some beneficts to this PR : #493, if developer override the deletion modal to provide one (for example) using a TextController to ensure that user well want to delete his account (no miss click), the recall of the confirmation will present twice a TextController to fill.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?