-
Notifications
You must be signed in to change notification settings - Fork 126
feat(ui_firestore): Expose index to FirestoreItemBuilder #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Exposes itemBuilder index in FirestoreListView and FirestoreListView.separated to be consistent with flutter ListView.builder and ListView.separated.
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
@russellwheatley |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
@russellwheatley can this be merged? |
@jt274 - it seems fair enough to me. I've merged with latest |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Description
This PR exposes the
itemBuilder
index inFirestoreListView
andFirestoreListView.separated
to be consistent with flutter'sListView.builder
andListView.separated
. There are situations where an index is required, such as when numbering the list of items in the list view.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?