-
Notifications
You must be signed in to change notification settings - Fork 341
feat(auth): Update ActionCodeSettings
to support link_domain
and deprecate dynamic_link_domain
#884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Update ActionCodeSettings
to support link_domain
and deprecate dynamic_link_domain
#884
Conversation
@lahirumaramba @pashanka see here re: #883. In my org we're currently relying on this via a fork and would be great to get into main release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1d9d933
to
dfce7c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @huwmartin for putting this together! Overall LGTM with one minor change below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please address the lint error and update the branch, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thanks!
@jonathanedey thanks, lots of other issues when running |
@huwmartin, no worries, those were mainly because the branch was out of date. We made some lint changes in or last release and the CI here are using those settings. Thanks again for you contribution! |
ActionCodeSettings
to support link_domain
and deprecate dynamic_link_domain
ActionCodeSettings
to support link_domain
and deprecate dynamic_link_domain
ActionCodeSettings
to support link_domain
and deprecate dynamic_link_domain
Discussion
Firebase Dynamic Links will stop working August 25th 2025.
Migration instructions indicate that to use a custom domain one should update usage of
ActionCodeSettings
to uselinkDomain
, see also in the Firebase Admin docs.We currently depend upon
generate_sign_in_with_email_link
to generate email links,firebase-admin-python
hasn't been updated withlink_domain
and currently only supportsdynamic_link_domain
,firebase-admin-node
has been updated with support forlinkDomain
so I assume this should be officially supported, please let me know if this is not the case.See #883.
This PR updates
ActionCodeSettings
to acceptlink_domain
and updatesencode_action_code_settings
to handlelink_domain
when constructing request payload. I have also added definition for newInvalidHostingLinkDomainError
error.