Skip to content

Update support for type hints #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

ViktorSky
Copy link

This PR originates from #886.

jonathanedey and others added 7 commits June 12, 2025 13:16
…3 to CIs (firebase#892)

* chore(deps): Bump minimum supported Python version to 3.9 and add 3.13 to CIs

* fix deprecation warnings

* fix GHA build status svg

* fix: Correctly scope async eventloop

* fix: Bump pylint to v2.7.4 and astroid to v2.5.8 to fix lint issues

* fix ml tests

* fix lint

* fix: remove commented code
* chore: Bump pylint to v3

* chore: fix src lint

* chore: fix unit test lint

* chore: fix integration test lint

* chore: fix snippets lint

* chore: 2nd pass for errors

* fix: corrected use of the `bad-functions` config

* fix: add EoF newline
- fix some pylint issues
…ependencies (firebase#897)

* chore: Bump dependencies

* fix: Also update setup.py
@jonathanedey jonathanedey self-requested a review July 3, 2025 14:12
@ViktorSky
Copy link
Author

Is there any progress?

@heckad
Copy link

heckad commented Jul 25, 2025

@ViktorSky, please do rebase.

@heckad
Copy link

heckad commented Jul 26, 2025

Please add a py.typed marker and why the version is 6.9.0. Is it the correct rebase?

@ViktorSky
Copy link
Author

What do you mean by version 6.9.0?

@heckad
Copy link

heckad commented Jul 31, 2025

If I try to install package from your brunch I got 6.9.0 version. Command to reproduce

poetry add firebase-admin@git+https://github.com/ViktorSky/firebase-admin-python.git#v7

@ViktorSky
Copy link
Author

@heckad pyproject.toml is not currently implemented, so it is normal that it does not work

@jonathanedey
Copy link
Contributor

Hi @ViktorSky , this PR should be rebased back against master now that the v7 changes have been merged. Unfortunately, as mentioned before, I can't promise a timeline for reviews on this since this is not currently prioritized on our roadmap.

@ViktorSky
Copy link
Author

Hi @ViktorSky , this PR should be rebased back against master now that the v7 changes have been merged. Unfortunately, as mentioned before, I can't promise a timeline for reviews on this since this is not currently prioritized on our roadmap.

So I close this one and I have to open a new one for the master?

@jonathanedey
Copy link
Contributor

No you should be able to do this without creating a new PR by editing the target branch in the GitHub UI above and performing a rebase on your local branch.

@ViktorSky ViktorSky changed the base branch from v7 to master August 1, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants