-
Notifications
You must be signed in to change notification settings - Fork 343
Update support for type hints #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…3 to CIs (firebase#892) * chore(deps): Bump minimum supported Python version to 3.9 and add 3.13 to CIs * fix deprecation warnings * fix GHA build status svg * fix: Correctly scope async eventloop * fix: Bump pylint to v2.7.4 and astroid to v2.5.8 to fix lint issues * fix ml tests * fix lint * fix: remove commented code
* chore: Bump pylint to v3 * chore: fix src lint * chore: fix unit test lint * chore: fix integration test lint * chore: fix snippets lint * chore: 2nd pass for errors * fix: corrected use of the `bad-functions` config * fix: add EoF newline
- fix some pylint issues
…ependencies (firebase#897) * chore: Bump dependencies * fix: Also update setup.py
Is there any progress? |
@ViktorSky, please do rebase. |
Please add a py.typed marker and why the version is 6.9.0. Is it the correct rebase? |
What do you mean by version 6.9.0? |
If I try to install package from your brunch I got 6.9.0 version. Command to reproduce poetry add firebase-admin@git+https://github.com/ViktorSky/firebase-admin-python.git#v7 |
@heckad pyproject.toml is not currently implemented, so it is normal that it does not work |
Hi @ViktorSky , this PR should be rebased back against master now that the v7 changes have been merged. Unfortunately, as mentioned before, I can't promise a timeline for reviews on this since this is not currently prioritized on our roadmap. |
So I close this one and I have to open a new one for the master? |
No you should be able to do this without creating a new PR by editing the target branch in the GitHub UI above and performing a rebase on your local branch. |
This PR originates from #886.