Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GMavenService #6644

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Implement GMavenService #6644

merged 5 commits into from
Jan 28, 2025

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jan 24, 2025

Per b/392134866,

This implements a centralized interface for communicating with GMaven called GMavenService. This service implements the gradle build-service interface to provide proper parallel access, and keeps local ConcurrentHashMap instances to cache responses.

Cached responses are on a per-build basis, to avoid improper caching of dynamic data. That is, given any build- all tasks that utilize GMavenService will share the responses from GMaven; even within a parallel environment. But if the tasks are considered out-of-date and are ran again, then new requests will be made to the GMaven backend.

Tests and documentation are provided for everything added as well.

Note that while this PR implements GMavenService- it does not refactor the existing GMavenHelper and RepositoryClient usages to use it. That will occur in subsequent PRs, as to avoid polluting this PR. Furthermore, while there are no tests for PomElement directly- in a future PR that includes tests for bom generation, PomElement will be tested as a by-product.

This PR also fixes the following:

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

Copy link
Contributor

github-actions bot commented Jan 24, 2025

plugins test results

49 tests   49 ✅  1m 24s ⏱️
 9 suites   0 💤
 9 files     0 ❌

Results for commit ef98216.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Test Results

 1 034 files  + 1 014   1 034 suites  +1 014   34m 33s ⏱️ + 34m 21s
 5 888 tests + 5 775   5 866 ✅ + 5 753  22 💤 +22  0 ❌ ±0 
11 839 runs  +11 613  11 795 ✅ +11 569  44 💤 +44  0 ❌ ±0 

Results for commit ef98216. ± Comparison against base commit 8567a38.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.74% (8567a38) to 45.74% (e3adba9) by -0.00%.

    FilenameBase (8567a38)Merge (e3adba9)Diff
    SetMutation.java97.22%94.44%-2.78%
  • firebase-storage

    Overall coverage changed from 84.12% (8567a38) to 83.92% (e3adba9) by -0.21%.

    FilenameBase (8567a38)Merge (e3adba9)Diff
    StorageTask.java83.69%83.38%-0.30%
    StreamDownloadTask.java88.89%88.41%-0.48%
    UploadTask.java82.51%81.52%-0.99%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/19TRUcLJRV.html

@daymxn daymxn requested a review from rlazo January 28, 2025 18:03
@daymxn daymxn merged commit b17d041 into main Jan 28, 2025
264 checks passed
@daymxn daymxn deleted the daymon-implement-gmavenservice branch January 28, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants