Exclude protolite well known types from version bump. #6909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Test Results 1 016 files + 1 016 1 016 suites +1 016 34m 28s ⏱️ + 34m 28s For more details on these failures, see this check. Results for commit 3441850. ± Comparison against base commit 4fb4dfd. ♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs |
rlazo
approved these changes
Apr 24, 2025
emilypgoogle
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/413403910,
This adds filtering logic to not bump the version of
protolite-well-known-typeswhen it releases. This solves the issue of theversionandlatestReleasedVersionnot aligning (which must be enforced due to b/285892320).More specifically, this PR adds a toggle for the default
bumpbehavior inVersionBumpTask. We then set this tofalsewhen the project'sartifactIdisprotolite-well-known-types.This allows us to still [automatically] update the
latestReleasedVersion(should we ever release well known types again), without bumping theversion.The
VersionBumpTaskdocs have been updated to accommodate this.