[infra] Bump AGP to 8.6 and gradle to 8.7 #7057
Conversation
Migrating to a version of AGP that supports API Level 35. See https://developer.android.com/build/releases/past-releases/agp-8-6-0-release-notes
Firebase AI Mock Responses Check
|
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on critical infrastructure updates by upgrading both the Android Gradle Plugin (AGP) and the core Gradle version. The primary motivation for these changes is to enable support for Android API Level 35, ensuring the project remains current with Android's evolving platform requirements and can leverage the latest build tool features and performance enhancements.
Highlights
- Android Gradle Plugin (AGP) Upgrade: The Android Gradle Plugin (AGP) has been updated from version
8.3.2to8.6.1. This upgrade is essential for supporting Android API Level 35, as noted in the PR description, ensuring compatibility with the latest Android development requirements. - Gradle Version Update: The project's Gradle version has been bumped from
8.4to8.7. This update aligns with the new AGP version and brings general improvements and stability to the build system. - Gradle Wrapper Script Enhancements: The
gradlewscript has received several minor updates to improve its robustness and POSIX compliance. These include changes to how thejavaexecutable is located and howcdcommand output is handled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin to version 8.6.1 and Gradle to version 8.7. The changes include version bumps in configuration files and updates to the Gradle wrapper scripts. The updates to gradlew improve robustness and security, such as safer argument handling, and the addition of validateDistributionUrl=true enhances security. A minor comment discrepancy in the gradlew script has been identified for improved clarity.
Size Report 1Affected ProductsNo changes between base commit (9b510c4) and merge commit (1c844bf).Test Logs |
Coverage Report 1Affected Products
Test Logs |
Migrating to a version of AGP that supports API Level 35.
See https://developer.android.com/build/releases/past-releases/agp-8-6-0-release-notes