-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[DynamicLinks] Remove library and corresponding infra #14978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
457d448
4eba7ac
6b011ad
b1dc360
8eb157a
5ec8ee5
55a1d9e
e3cb144
64cebfa
d07d19a
fdea971
c4d4b95
57e4533
b035e35
1f00217
6261153
14d20a5
022f89f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,6 @@ | |
auth_run_job: ${{ steps.check_files.outputs.auth_run_job }} | ||
crashlytics_run_job: ${{ steps.check_files.outputs.crashlytics_run_job }} | ||
database_run_job: ${{ steps.check_files.outputs.database_run_job }} | ||
dynamiclinks_run_job: ${{ steps.check_files.outputs.dynamiclinks_run_job }} | ||
firestore_run_job: ${{ steps.check_files.outputs.firestore_run_job }} | ||
functions_run_job: ${{ steps.check_files.outputs.functions_run_job }} | ||
inappmessaging_run_job: ${{ steps.check_files.outputs.inappmessaging_run_job }} | ||
|
@@ -126,29 +125,6 @@ | |
name: codecoverage | ||
path: /Users/runner/*.xcresult | ||
|
||
pod-lib-lint-dynamiclinks: | ||
needs: check | ||
# Don't run on private repo unless it is a PR. | ||
if: always() && github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.dynamiclinks_run_job == 'true'|| github.event.pull_request.merged) | ||
runs-on: macos-14 | ||
strategy: | ||
matrix: | ||
target: [iOS] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
with: | ||
cache_key: ${{ matrix.os }} | ||
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
- name: Setup Bundler | ||
run: scripts/setup_bundler.sh | ||
- name: Build and test | ||
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDynamicLinks --platform=${{ matrix.target }} | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: codecoverage | ||
path: /Users/runner/*.xcresult | ||
|
||
pod-lib-lint-firestore: | ||
needs: check | ||
# Don't run on private repo unless it is a PR. | ||
|
@@ -317,71 +293,71 @@ | |
path: /Users/runner/*.xcresult | ||
|
||
create_report: | ||
needs: [check, pod-lib-lint-abtesting, pod-lib-lint-auth, pod-lib-lint-database, pod-lib-lint-dynamiclinks, pod-lib-lint-firestore, pod-lib-lint-functions, pod-lib-lint-inappmessaging, pod-lib-lint-messaging, pod-lib-lint-performance, pod-lib-lint-remoteconfig, pod-lib-lint-storage] | ||
needs: [check, pod-lib-lint-abtesting, pod-lib-lint-auth, pod-lib-lint-database, pod-lib-lint-firestore, pod-lib-lint-functions, pod-lib-lint-inappmessaging, pod-lib-lint-messaging, pod-lib-lint-performance, pod-lib-lint-remoteconfig, pod-lib-lint-storage] | ||
if: always() | ||
runs-on: macos-14 | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: Access to Metrics Service | ||
if: github.event.pull_request.head.repo.full_name == github.repository && (github.event.action != 'closed' || github.event.pull_request.merged) | ||
run: | | ||
# Install gcloud sdk | ||
curl https://sdk.cloud.google.com > install.sh | ||
bash install.sh --disable-prompts | ||
echo "${HOME}/google-cloud-sdk/bin/" >> $GITHUB_PATH | ||
export PATH="${HOME}/google-cloud-sdk/bin/:${PATH}" | ||
|
||
# Activate the service account for Metrics Service. | ||
scripts/decrypt_gha_secret.sh scripts/gha-encrypted/metrics_service_access.json.gpg \ | ||
metrics-access.json "${{ env.METRICS_SERVICE_SECRET }}" | ||
gcloud auth activate-service-account --key-file metrics-access.json | ||
- uses: actions/[email protected] | ||
id: download | ||
with: | ||
path: /Users/runner/test | ||
- name: Compare Diff and Post a Report | ||
if: github.event.pull_request.merged != true && github.event.action != 'closed' && github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.base.ref == 'main' | ||
env: | ||
base_commit: ${{ needs.check.outputs.target_branch_head }} | ||
run: | | ||
# Get Head commit of the branch, instead of a merge commit created by actions/checkout. | ||
if [ -d "${{steps.download.outputs.download-path}}" ]; then | ||
cd scripts/health_metrics/generate_code_coverage_report | ||
swift run CoverageReportGenerator --presubmit "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --pull-request-num ${{github.event.pull_request.number}} --base-commit "$base_commit" | ||
fi | ||
# Will reactivate the job after the issue #8305 is resovled. | ||
# - name: Incremental Code Coverage | ||
# if: github.event.pull_request.merged != true && github.event.action != 'closed' | ||
# env: | ||
# base_commit: ${{ needs.check.outputs.base_commit }} | ||
# run: | | ||
# # Get Head commit of the branch, instead of a merge commit created by actions/checkout. | ||
# GITHUB_SHA=$(cat $GITHUB_EVENT_PATH | jq -r .pull_request.head.sha) | ||
# # Get a JSON of `git diff` from the base commit. | ||
# git diff -U0 ${base_commit} "${GITHUB_SHA}" | scripts/health_metrics/git_diff_to_json.sh > scripts/health_metrics/generate_code_coverage_report/git_diff.json | ||
# cat "scripts/health_metrics/generate_code_coverage_report/git_diff.json" | ||
# if [ -d "${{steps.download.outputs.download-path}}" ]; then | ||
# # Create an uncovered_file_lines.json including code lines not covered by tests. | ||
# cd scripts/health_metrics/generate_code_coverage_report | ||
# swift run IncrementalCoverageReportGenerator --changed-files "git_diff.json" --file-archive-root-path "${GITHUB_WORKSPACE}" --xcresult-dir "${{steps.download.outputs.download-path}}" --uncovered-line-file-json "uncovered_file_lines.json" | ||
# # Post uncovered lines to PRs. | ||
# pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH") | ||
# cd .. | ||
# bundle install | ||
# INPUT_ACCESS_TOKEN=${{ secrets.GITHUB_TOKEN }} \ | ||
# GITHUB_REPOSITORY="${GITHUB_REPOSITORY}" \ | ||
# UNCOVERED_LINE_FILE="generate_code_coverage_report/uncovered_file_lines.json" \ | ||
# TESTING_COMMIT="${GITHUB_SHA}" \ | ||
# PULL_REQUEST="${pull_number}" \ | ||
# bundle exec ruby post_incremental_coverage_in_pr.rb | ||
# fi | ||
- name: Update New Coverage Data | ||
if: github.event.pull_request.merged && github.event.pull_request.head.repo.full_name == github.repository | ||
run: | | ||
if [ -d "${{steps.download.outputs.download-path}}" ]; then | ||
cd scripts/health_metrics/generate_code_coverage_report | ||
swift run CoverageReportGenerator --merge "firebase/firebase-ios-sdk" --head-commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --source-branch "${{ github.base_ref }}" | ||
fi | ||
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,8 @@ | |
// Uncomment next line if ABTesting gets added to Firebase.h. | ||
// class ABTestingExists : LifecycleEvents {} | ||
class DatabaseExists: Database {} | ||
class DynamicLinksExists: DynamicLinks {} | ||
class FirestoreExists: Firestore {} | ||
class FunctionsExists: Functions {} | ||
Check warning on line 29 in CoreOnly/Tests/FirebasePodTest/FirebasePodTest/AppDelegate.swift
|
||
class InAppMessagingExists: InAppMessaging {} | ||
class InAppMessagingDisplayExists: InAppMessagingDisplay { // protocol instead of interface | ||
func displayMessage(_ messageForDisplay: InAppMessagingDisplayMessage, | ||
|
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.