Remove null / nan related operations #15441
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
cherylEnkidu
changed the title
| .sort([Field("rating").descending()]) | ||
| .limit(1) | ||
| .select( | ||
| [ |
There was a problem hiding this comment.
Instead of deleting them, you can add Field(rating) == nil instead.
There was a problem hiding this comment.
I will add back this test. But the iOS SDK only implemented operator overload for ^, !, and ||. So it is still Field(rating).equals(nil)
|
|
||
| switch (op) { | ||
| case FieldFilter::Operator::LessThan: | ||
| func_name = "lt"; |
There was a problem hiding this comment.
Should these functions be renamed?
There was a problem hiding this comment.
yes, this part would be address when fixing realtime ppl implementation. So it is not included in this PR.
3 participants
#no-changelog