Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use .mjs extension for modules #6748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use .mjs extension for modules #6748

wants to merge 1 commit into from

Conversation

levino
Copy link

@levino levino commented Nov 2, 2022 •
edited
Loading

fix #6747

I think making this library an "es module" is going to create a lot of fall out. Instead I suggest to use the ".mjs" file extension.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5f325b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Nov 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@levino levino force-pushed the master branch 2 times, most recently from 8f5f42c to 7bcf165 Compare November 2, 2022 11:47
@levino
Copy link
Author

levino commented Nov 2, 2022

Will the checks run on a draft?

@levino levino marked this pull request as ready for review November 2, 2022 15:12
@levino levino mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

@erikeldridge erikeldridge Awaiting requested review from erikeldridge erikeldridge is a code owner

@jposuna jposuna Awaiting requested review from jposuna

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@yoyomyo yoyomyo Awaiting requested review from yoyomyo yoyomyo is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@jsdt jsdt Awaiting requested review from jsdt

@jmwski jmwski Awaiting requested review from jmwski

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jest does not work with Firebase out of the box
1 participant
@levino