Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Add tests to verify bundles produced by rollup #7972

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 22, 2024

This PR adds a test suite to perform some checks on the bundles produced by rollup for Firestore. The immediate motivation for this test suite is to provide an automated way to validate the "development" bundles proposed in #7945.

Work In Progress

This PR is a work-in-progress. As of Jan 22, 2024, work on this PR has been de-prioritized but I'm leaving it here so it can be picked up in the future. Googlers see b/302682954 for details.

@dconeybe dconeybe self-assigned this Jan 22, 2024
Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: 1ae1d19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (434f841)Merge (5b0d73a)Diff
    browser375 kB375 kB+55 B (+0.0%)
    esm5360 kB360 kB+50 B (+0.0%)
    main577 kB577 kB+132 B (+0.0%)
    module375 kB375 kB+55 B (+0.0%)
    react-native375 kB375 kB+56 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (434f841)Merge (5b0d73a)Diff
    browser109 kB109 kB+50 B (+0.0%)
    esm5106 kB106 kB+51 B (+0.0%)
    main150 kB150 kB+129 B (+0.1%)
    module109 kB109 kB+50 B (+0.0%)
    react-native109 kB109 kB+41 B (+0.0%)
  • firebase

    TypeBase (434f841)Merge (5b0d73a)Diff
    firebase-firestore-lite.js117 kB117 kB+50 B (+0.0%)
    firebase-firestore.js434 kB435 kB+61 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qWdnAbUOtS.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • _ROLLUP_BUNDLE_ID

      Size

      TypeBase (434f841)Merge (5b0d73a)Diff
      size?17.8 kB? (?)
      size-with-ext-deps?87.6 kB? (?)

      Dependency

      TypeBase (434f841)Merge (5b0d73a)Diff
      functions?

      12 dependencies

      __PRIVATE_argToString
      __PRIVATE_cloneLongPollingOptions
      __PRIVATE_configureFirestore
      __PRIVATE_hardAssert
      __PRIVATE_isIndexedDbTransactionError
      __PRIVATE_logDebug
      __PRIVATE_logError
      __PRIVATE_randomBytes
      __PRIVATE_validateIsNotUsedTogether
      __PRIVATE_wrapInUserErrorIfRecoverable
      fail
      getDocument

      ?
      classes?

      20 dependencies

      AppCheckToken
      DatabaseId
      DatabaseInfo
      DelayedOperation
      Firestore
      Firestore$1
      FirestoreClient
      FirestoreError
      FirestoreSettingsImpl
      User
      __PRIVATE_AsyncQueueImpl
      __PRIVATE_AutoId
      __PRIVATE_Deferred
      __PRIVATE_EmptyAuthCredentialsProvider
      __PRIVATE_ExponentialBackoff
      __PRIVATE_FirebaseAppCheckTokenProvider
      __PRIVATE_FirebaseAuthCredentialsProvider
      __PRIVATE_FirstPartyAuthCredentialsProvider
      __PRIVATE_FirstPartyToken
      __PRIVATE_OAuthToken

      ?
      variables?

      D
      S
      ae
      b
      be
      me
      ue
      w

      ?
      enums??

      External Dependency

      ModuleBase (434f841)Merge (5b0d73a)Diff
      @firebase/app?

      SDK_VERSION
      _registerComponent
      registerVersion

      ?
      @firebase/component?

      Component

      ?
      @firebase/logger?

      LogLevel
      Logger

      ?
      @firebase/util?

      FirebaseError

      ?
      @firebase/webchannel-wrapper?

      Integer

      ?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pomB4tJYPk.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants