Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable auth redirect tests #8803

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Re-enable auth redirect tests #8803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2223b51
Re-enable redirect tests
NhienLam Feb 20, 2025
c877e2e
Fix lint
NhienLam Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/auth/test/integration/webdriver/redirect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,11 +332,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
expect(user.email).to.eq(user1.email);
});

it('reauthenticate throws for wrong user', async function () {
// Test is ignored for now as it fails on Chrome version 111+.
// TODO(b/297245662): Investigate and unskip the test.
this.skip();

it('reauthenticate throws for wrong user', async () => {
// Sign in using pre-populated user
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);

Expand All @@ -359,11 +355,7 @@ browserDescribe('WebDriver redirect IdP test', driver => {
);
});

it('handles aborted sign ins', async function () {
// Test is ignored for now as it fails on Chrome version 111+.
// TODO(b/297245662): Investigate and unskip the test.
this.skip();

it('handles aborted sign ins', async () => {
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
const widget = new IdPPage(driver.webDriver);

Expand Down
Loading