Complete Hybrid inference impl #8966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsiddh
requested review from
a team,
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
mansisampat and
NhienLam
as code owners
|
gsiddh
force-pushed
the
vaihi-exp-google-ai
branch
from
cae765f to
92aa31a
Compare
Size Report 1Affected Products
Test Logs |
gsiddh
force-pushed
the
vaihi-exp-google-ai
branch
3 times, most recently
from
5786936 to
258c622
Compare
Size Analysis Report 1This report is too large (89,334 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
gsiddh
force-pushed
the
vaihi-exp-google-ai
branch
from
258c622 to
3f5ebab
Compare
Fix languageCode parameter in action_code_url (#8912) * Fix languageCode parameter in action_code_url * Add changeset Vaihi add langmodel types. (#8927) * Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl * Adding LanguageModel types. * Remove bunch of exports * yarn formatted * after lint Define HybridParams (#8935) Co-authored-by: Erik Eldridge <[email protected]> Adding smoke test for new hybrid params (#8937) * Adding smoke test for new hybrid params * Use the existing name of the model params input --------- Co-authored-by: Erik Eldridge <[email protected]> Moving to in-cloud naming (#8938) Co-authored-by: Erik Eldridge <[email protected]> Moving to string type for the inference mode (#8941) Define ChromeAdapter class (#8942) Co-authored-by: Erik Eldridge <[email protected]> VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943) Adding count token impl (#8950) VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949) Define values for Availability enum (#8951) VinF Hybrid Inference: narrow Chrome input type (#8953) Add image inference support (#8954) * Adding image based input for inference * adding image as input to create language model object disable count tokens api for on-device inference (#8962) VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh
force-pushed
the
vaihi-exp-google-ai
branch
from
3f5ebab to
abf0491
Compare
tomayac
reviewed
Apr 25, 2025
| private mode?: InferenceMode, | ||
| private onDeviceParams: LanguageModelCreateOptions = {} | ||
| ) { | ||
| this.addImageTypeAsExpectedInput(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix languageCode parameter in action_code_url (#8912)
Fix languageCode parameter in action_code_url
Add changeset
Vaihi add langmodel types. (#8927)
Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl
Adding LanguageModel types.
Remove bunch of exports
yarn formatted
after lint
Define HybridParams (#8935)
Co-authored-by: Erik Eldridge [email protected]
Adding smoke test for new hybrid params (#8937)
Adding smoke test for new hybrid params
Use the existing name of the model params input
Co-authored-by: Erik Eldridge [email protected]
Moving to in-cloud naming (#8938)
Co-authored-by: Erik Eldridge [email protected]
Moving to string type for the inference mode (#8941)
Define ChromeAdapter class (#8942)
Co-authored-by: Erik Eldridge [email protected]
VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)
Adding count token impl (#8950)
VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)
Define values for Availability enum (#8951)
VinF Hybrid Inference: narrow Chrome input type (#8953)
Add image inference support (#8954)
Adding image based input for inference
adding image as input to create language model object
disable count tokens api for on-device inference (#8962)
VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.