[Firebase AI] Add thought summary and signature support #9192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f62f8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cc: @dlarocque |
hsubox76
reviewed
Aug 8, 2025
| export function getText(response: GenerateContentResponse): string { | ||
| export function getText( | ||
| response: GenerateContentResponse, | ||
| isThought: boolean |
There was a problem hiding this comment.
Maybe instead of passing a specific boolean for thoughts we pass through a filter function here:
partFilter: () => boolean
and then when we call it in addHelpers() above it's like getText(response, (part) => !part.thought) for text() and it's getText(response, (part) => part.thought) for thoughtSummary(). And then in the condition below it's if (part.text && partFilter(part))
This makes it read clearly when it's called (or we can just add a comment before true and false). It might get unwieldy if we have other kinds of text parts in the future that have more complex logic though.
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - Added support for including thought summaries and thought signatures.
Manually tested through the quickstart but still needs unit tests and deciding if the approach in
getTextmakes sense. Chat handling will also need to be implemented.