Skip to content

Removed unnecessary types #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removed unnecessary types #9372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f581d23
Removed unnecessary types
maneesht Nov 10, 2025
bc442f1
Fixed build and formatting issues
maneesht Nov 11, 2025
c4640e9
Create proud-trainers-live.md
maneesht Nov 11, 2025
c087753
Fixed testing
maneesht Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions common/api-review/data-connect.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@

```ts

import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
import { FirebaseApp } from '@firebase/app';
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
import { FirebaseError } from '@firebase/util';
import { LogLevelString } from '@firebase/logger';
import { Provider } from '@firebase/component';

// @public
export type CallerSdkType = 'Base' | 'Generated' | 'TanstackReactCore' | 'GeneratedReact' | 'TanstackAngularCore' | 'GeneratedAngular';
Expand Down Expand Up @@ -53,7 +50,6 @@ export interface ConnectorConfig {

// @public
export class DataConnect {
constructor(app: FirebaseApp, dataConnectOptions: DataConnectOptions, _authProvider: Provider<FirebaseAuthInternalName>, _appCheckProvider: Provider<AppCheckInternalComponentName>);
// (undocumented)
readonly app: FirebaseApp;
// (undocumented)
Expand Down Expand Up @@ -97,12 +93,6 @@ export interface DataConnectOperationFailureResponseErrorInfo {
readonly path: Array<string | number>;
}

// @public
export interface DataConnectOptions extends ConnectorConfig {
// (undocumented)
projectId: string;
}

// @public (undocumented)
export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
// (undocumented)
Expand Down Expand Up @@ -216,7 +206,7 @@ export type ReferenceType = typeof QUERY_STR | typeof MUTATION_STR;
// @public
export interface RefInfo<Variables> {
// (undocumented)
connectorConfig: DataConnectOptions;
connectorConfig: ConnectorConfig;
// (undocumented)
name: string;
// (undocumented)
Expand Down
4 changes: 3 additions & 1 deletion packages/data-connect/src/api/DataConnect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ export class DataConnect {
_isUsingGeneratedSdk: boolean = false;
_callerSdkType: CallerSdkType = CallerSdkTypeEnum.Base;
private _appCheckTokenProvider?: AppCheckTokenProvider;
// @internal
/**
* @hideconstructor
*/
constructor(
public readonly app: FirebaseApp,
// TODO(mtewani): Replace with _dataConnectOptions in the future
Expand Down
4 changes: 2 additions & 2 deletions packages/data-connect/src/api/Reference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

import { DataConnect, DataConnectOptions } from './DataConnect';
import { ConnectorConfig, DataConnect } from './DataConnect';
export const QUERY_STR = 'query';
export const MUTATION_STR = 'mutation';
export type ReferenceType = typeof QUERY_STR | typeof MUTATION_STR;
Expand Down Expand Up @@ -48,7 +48,7 @@ export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
export interface RefInfo<Variables> {
name: string;
variables: Variables;
connectorConfig: DataConnectOptions;
connectorConfig: ConnectorConfig;
}
/**
* Serialized Ref as a result of `QueryResult.toJSON()`
Expand Down
2 changes: 1 addition & 1 deletion packages/data-connect/src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

export * from '../network';
export * from './DataConnect';
export { ConnectorConfig, DataConnect, TransportOptions, areTransportOptionsEqual, connectDataConnectEmulator, getDataConnect, parseOptions, terminate, validateDCOptions } from './DataConnect';
export * from './Reference';
export * from './Mutation';
export * from './query';
Expand Down
Loading