Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serialize-javascript from 6.0.1 to 6.0.2 in /scripts/webframeworks-deploy-tests/angular #8212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Bump serialize-javascript from 6.0.1 to 6.0.2 in /scripts/webframeworks-deploy-tests/angular #8212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/webframeworks-deploy-tests/angular/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Unchanged files with check annotations Beta

View file
firebase-vscode/src/core/emulators.ts
// Subscription to trigger emulator exports when button is clicked.
this.subscriptions.push(broker.on("runEmulatorsExport", () => {
vscode.commands.executeCommand("firebase.emulators.exportData")

Check warning on line 45 in firebase-vscode/src/core/emulators.ts

GitHub Actions / lint (20) 

Missing semicolon
}));
}
View file
firebase-vscode/src/data-connect/sdk-generation.ts
(args: { appFolder: string }) => {
analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.INIT_SDK_CLI);
// Lets do it from the right directory
const e: Record<string, string> = {}

Check warning on line 43 in firebase-vscode/src/data-connect/sdk-generation.ts

GitHub Actions / lint (20) 

Missing semicolon
e[FDC_APP_FOLDER] = args.appFolder;
setTerminalEnvVars(e);
runCommand(`${settings.firebasePath} init dataconnect:sdk`);
View file
firebase-vscode/src/test/integration/fishfood/execution.ts
import { FirebaseSidebar } from "../../utils/page_objects/sidebar";
import { mockUser } from "../../utils/user";
import { Workbench, Notification } from "wdio-vscode-service";
import {Notifications} from "../../utils/page_objects/notifications"

Check warning on line 13 in firebase-vscode/src/test/integration/fishfood/execution.ts

GitHub Actions / lint (20) 

Missing semicolon
firebaseSuite("Execution", async function () {
firebaseTest(
expect(startEmulatorsNotif).toExist();
// should always exist due to check above; Click Yes
if (startEmulatorsNotif)
notificationUtil.startEmulatorFromNotification(startEmulatorsNotif);

Check warning on line 45 in firebase-vscode/src/test/integration/fishfood/execution.ts

GitHub Actions / lint (20) 

Expected { after 'if' condition
console.log(
"Starting emulators from local execution. Waiting for emulators to start...",