Update brace-expansion to 1.1.12 across all uses

[joehan]

Description

Testing out using Gemini to update dependencies, starting with a very minor one that has a low risk vulnerability.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a widespread dependency update for the brace-expansion package to mitigate a low-risk vulnerability. The changes span across various modules and test environments, updating both direct and transitive dependencies, and aligning Node.js engine requirements. This also acts as a practical test for an automated dependency update process.

Highlights

• Dependency Update: The brace-expansion npm package has been updated to version 4.0.1 across numerous package.json and package-lock.json files throughout the repository. This update addresses a low-risk vulnerability present in older versions of the package.
• Transitive Dependency Alignment: As part of the brace-expansion upgrade, its direct dependency balanced-match has also been updated to 3.0.1 in many package-lock.json files. Older concat-map dependencies associated with brace-expansion have been removed.
• Node.js Engine Requirements: The package-lock.json files now reflect updated Node.js engine requirements for brace-expansion (requiring >= 18) and balanced-match (requiring >= 16), ensuring compatibility with modern Node.js environments.
• Automated Update Process: This pull request serves as a test case for using Gemini to automate dependency updates, demonstrating its capability for managing minor, low-risk vulnerability patches.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the brace-expansion dependency across the monorepo, likely to address a vulnerability. While the goal is good, the implementation has a few issues. My review highlights a more idiomatic approach using npm overrides for cleaner dependency management, points out an inconsistency in the target version of brace-expansion (1.1.12 vs. 4.0.1), and flags a potentially unintentional Node.js engine version bump in one of the packages.

[gemini-code-assist]

Adding brace-expansion as a direct dependency in multiple package.json files is not the ideal way to resolve a vulnerability in a transitive dependency within a monorepo. This approach leads to dependency bloat and can cause version conflicts, as different parts of the project might resolve to different versions of brace-expansion.

A cleaner solution is to use overrides in the root package.json to enforce a single version across all workspaces. For example:

"overrides": {
  "brace-expansion": "1.1.12"
}

This would update the vulnerable package to 1.1.12 (which aligns with the PR title and is a safe patch) without adding it as a direct dependency everywhere. This also avoids the major version jump to 4.0.1, which could introduce breaking changes and contradicts the PR description of a "very minor" update.

Please consider using overrides and targeting a consistent, safe version.

[gemini-code-assist]

The engines.node requirement has been bumped from >=18.0.0 to >=20.0.0. This seems unrelated to the brace-expansion update, as [email protected] only requires Node.js >=18. Was this change intentional? If not, it should probably be reverted to avoid imposing a stricter Node.js version requirement than necessary.

        "node": ">=18.0.0"