Skip to content

Comments

Refactor Github Action per b/485167538#1397

Merged
a-maurice merged 6 commits intomainfrom
lsc-1771416096.7419882
Feb 20, 2026
Merged

Refactor Github Action per b/485167538#1397
a-maurice merged 6 commits intomainfrom
lsc-1771416096.7419882

Conversation

@google-admin
Copy link
Contributor

This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538.

This is a PR to help you upgrade to the latest standards in Github Actions.

Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See http://b/485167538 for more details.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 18, 2026
@a-maurice a-maurice self-requested a review February 19, 2026 18:49
@a-maurice a-maurice assigned a-maurice and unassigned AustinBenoit Feb 19, 2026
@a-maurice a-maurice removed the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 19, 2026
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on good CI

@paulb777
Copy link
Member

Perhaps out of scope for this PR, but iOS has found it useful to trigger workflows on changes to workflow itself like https://github.com/firebase/firebase-ios-sdk/blob/main/.github/workflows/sdk.auth.yml#L12

@a-maurice
Copy link
Collaborator

a-maurice commented Feb 19, 2026

Perhaps out of scope for this PR, but iOS has found it useful to trigger workflows on changes to workflow itself like https://github.com/firebase/firebase-ios-sdk/blob/main/.github/workflows/sdk.auth.yml#L12

Yeah, we have that setup on C++. Unity has a problem with limited licenses though, so it is set up to require manual work. You can either add a label, but I tend to just manually kick it off (see https://github.com/firebase/firebase-unity-sdk/actions/runs/22203613060 for the most recent one), and when it all works, I add a link back to the commit to the working one.

@a-maurice
Copy link
Collaborator

Integration tests mostly pass, beyond some flakes

@a-maurice a-maurice merged commit 5d52a61 into main Feb 20, 2026
21 of 27 checks passed
@a-maurice a-maurice deleted the lsc-1771416096.7419882 branch February 20, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants