fix(core): move test related files from src to test directory#17023
fix(core): move test related files from src to test directory#17023SelaseKay wants to merge 3 commits intofirebase:mainfrom
Conversation
SelaseKay
changed the title
| import 'package:firebase_auth_platform_interface/src/method_channel/method_channel_firebase_auth.dart'; | ||
| import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'; | ||
| import 'package:firebase_core_platform_interface/test.dart'; | ||
| import '../../../firebase_core/firebase_core_platform_interface/test/test.dart'; |
There was a problem hiding this comment.
I think this is why we previously had flutter_test in dependencies as opposed to dev dependencies so we can share it with other packages. But, I don't think this matters because it will be excluded when publishing to pub.dev. Therefore, relative paths should be fine for other packages
There was a problem hiding this comment.
Just to double check, I'll see if @Lyokone has any feedback on the matter 😄
There was a problem hiding this comment.
Hum I'm wondering how it will fix the issue, we have not changed anything in the pubspec.yaml?
|
I don't think this will work, it seems tests/ directory is published as well and has to be explicitly ignored in |
|
I think the solution is to create a separate package for it. |
3 participants
Related Issues
Fixes #17001
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?