Builder refactor

[ShadowCurse]

Changes

This is another attempt at fixing #4547.

• Move architecture specific parts from builder.rs into arch modules.
• Do slight refactoring on top in the arch modules.

Reason

Less arch specific mess in the codebase.

Fixes: #4411
Previous attempt was: #4910

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

• I have read and understand CONTRIBUTING.md.
• I have run tools/devtool checkstyle to verify that the PR passes the
  automated style checks.
• I have described what is done in these changes, why they are needed, and
  how they are solving the problem in a clear and encompassing way.
• I have updated any relevant documentation (both in code and in the docs)
  in the PR.
• I have mentioned all user-facing changes in CHANGELOG.md.
• If a specific issue led to this PR, this PR closes the issue.
• When making API changes, I have followed the
  Runbook for Firecracker API changes.
• I have tested all new and changed functionalities in unit tests and/or
  integration tests.
• I have linked an issue to every new TODO.

---

• This functionality cannot be added in rust-vmm.

[codecov]

Codecov Report

Attention: Patch coverage is 93.66516% with 14 lines in your changes missing coverage. Please review.

Project coverage is 83.06%. Comparing base (a6c9559) to head (2c42f84).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/vmm/src/arch/x86_64/mod.rs	94.11%	5 Missing ⚠️
src/vmm/src/initrd.rs	84.61%	4 Missing ⚠️
src/vmm/src/arch/aarch64/mod.rs	98.48%	1 Missing ⚠️
src/vmm/src/builder.rs	80.00%	1 Missing ⚠️
src/vmm/src/cpu_config/aarch64/mod.rs	91.66%	1 Missing ⚠️
src/vmm/src/lib.rs	50.00%	1 Missing ⚠️
src/vmm/src/persist.rs	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5112      +/-   ##
==========================================
- Coverage   83.19%   83.06%   -0.14%     
==========================================
  Files         249      250       +1     
  Lines       26885    26888       +3     
==========================================
- Hits        22368    22334      -34     
- Misses       4517     4554      +37     

Flag	Coverage Δ
5.10-c5n.metal	83.52% <91.54%> (-0.09%)	⬇️
5.10-m5n.metal	83.52% <91.54%> (-0.09%)	⬇️
5.10-m6a.metal	82.71% <91.54%> (-0.09%)	⬇️
5.10-m6g.metal	79.43% <89.60%> (-0.18%)	⬇️
5.10-m6i.metal	83.52% <91.54%> (-0.08%)	⬇️
5.10-m7a.metal-48xl	82.71% <91.54%> (?)
5.10-m7g.metal	79.43% <89.60%> (-0.18%)	⬇️
6.1-c5n.metal	83.57% <91.54%> (-0.08%)	⬇️
6.1-m5n.metal	83.57% <91.54%> (-0.08%)	⬇️
6.1-m6a.metal	82.76% <91.54%> (-0.09%)	⬇️
6.1-m6g.metal	79.42% <89.60%> (-0.19%)	⬇️
6.1-m6i.metal	83.56% <91.54%> (-0.08%)	⬇️
6.1-m7a.metal-48xl	82.76% <91.54%> (?)
6.1-m7g.metal	79.43% <89.60%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[roypat]

thanks for indulging me with all those #[from]s :D