Add Notification Policy resource #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisJasso
force-pushed
the
add_notification_policy
branch
2 times, most recently
from
621f5d2 to
af81a50
Compare
AlexisJasso
force-pushed
the
add_notification_policy
branch
from
7387fed to
39276df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Notification Policy resource.
Testing using the
firehydrant-go-sdkas part of this. Of course, on checking, I found that the function for creating the policy resource is horribly misnamed. This has been corrected on the laddertruck side and will be updated here before this is to be merged. Construction with the new client is a little awkward, but I didn't want to break testing or initialization for anything other that the new resource to minimize any issues if this doesn't go well. If it does (as I expect it to), we can do a another update to initialize both clients properly and then move to the new one in pieces to make life easier on reviewers.