Skip to content

[BHP1-1511] Update Application to Use the New Directional Variables Attribute#196

Open
Kcheung42 wants to merge 8 commits intokc-BHP1-1510-vms-updatesfrom
kc-BHP1-1511-app-update
Open

[BHP1-1511] Update Application to Use the New Directional Variables Attribute#196
Kcheung42 wants to merge 8 commits intokc-BHP1-1510-vms-updatesfrom
kc-BHP1-1511-app-update

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

Purpose

Related Issues

Closes BHP1-1511

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Create a Surface Run
  2. Select output:
  • Direction Mode: Heading, Backing, Flanking
  • Rate of Spread
  • Flame Length
  • Fireline Intensity
  1. Make at least one multi valued input (to show graphs)
  2. Run worksheet and navigate to review page
  3. Notice there is no longer entries in either the table filters or the y-axis-limit table for directional outputs, just the directional parent exist (i.e. Rate of Spread, Flame Length, Fireline Intensity)
  4. Update one of the table filter settings
  5. Navigate to results and see that heading, backing, and flanking, tables are all filtered the same
  6. Do the same for the Y axis limit

Screenshots

@rjsheperd
Copy link
Copy Markdown
Contributor

When I run clj-kondo --lint $(git diff --name-only origin/main...HEAD | grep -E '\.(clj|cljc|cljs)$' | tr '\n' ' '), I get:

  • queries.cljc — 3 unused namespace requires: clojure.string, datascript.core, datahike.api
  • group_variables/views.cljs:104 — unused binding is-output?
  • group_variables/views.cljs:106 — unused binding action-id

@Kcheung42
Copy link
Copy Markdown
Collaborator Author

Kcheung42 commented Apr 1, 2026

I've updated queries.cljc. I don't see any lint issues for ns behave-cms.group-variables.views. Line 104 of this branch doesn't have is-output?. perhaps you ran this on a different branch?

all is-output? and action-id bindings are being used. As a side note, this PR didn't make any changes to queries.cljc. If we're having lint issues across the hold project, lets make a separate ticket and squash them all in one PR.

When I run `clj-kondo --lint $(git diff --name-only origin/main...HEAD | grep -E '.(clj|cljc|cljs)$' | tr '\n' ' ')

bases/behave_schema/src/behave/schema/group_variable.cljc:41:1: warning: Missing docstring.
bases/behave_schema/src/behave/schema/group_variable.cljc:166:76: error: unresolved symbol random-uuid
components/schema_migrate/src/schema_migrate/core.clj:217:1: warning: Missing docstring.
components/schema_migrate/src/schema_migrate/core.clj:379:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:61:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:73:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:87:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:115:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:122:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:124:25: warning: Unresolved namespace clojure.string. Are you missing a require?
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:133:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:141:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:155:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:158:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:174:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:241:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:265:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:271:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:284:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:293:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:310:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:341:1: warning: Missing docstring.
development/migrations/2026_03_03_add_direction_variables_attr_to_group_variables.clj:350:1: warning: Missing docstring.
projects/behave/src/cljs/behave/components/results/matrices.cljs:325:1: warning: Missing docstring.
projects/behave/src/cljs/behave/vms/subs.cljs:14:14: warning: duplicate require of re-frame.core
projects/behave/src/cljs/behave/vms/subs.cljs:163:12: warning: Shadowed var: cljs.core/uuid
projects/behave/src/cljs/behave/vms/subs.cljs:335:1: warning: Missing docstring.
projects/behave/src/cljs/behave/vms/subs.cljs:344:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:30:14: warning: duplicate require of re-frame.core
projects/behave/src/cljs/behave/wizard/views.cljs:36:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:39:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:57:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:138:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:176:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:185:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:197:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:254:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:299:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:299:57: warning: unused binding workflow
projects/behave/src/cljs/behave/wizard/views.cljs:369:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:390:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:604:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:604:81: warning: unused binding params
projects/behave/src/cljs/behave/wizard/views.cljs:653:1: warning: Missing docstring.
projects/behave/src/cljs/behave/wizard/views.cljs:653:72: warning: unused binding params
projects/behave/src/cljs/behave/wizard/views.cljs:757:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/events.cljs:4:14: warning: namespace behave.logger is required but never used
projects/behave/src/cljs/behave/worksheet/events.cljs:4:52: warning: #'behave.logger/log is referred but never used
projects/behave/src/cljs/behave/worksheet/events.cljs:17:17: warning: Unused private var behave.worksheet.events/q-worksheet
projects/behave/src/cljs/behave/worksheet/events.cljs:54:17: warning: Unused private var behave.worksheet.events/q-input-unit
projects/behave/src/cljs/behave/worksheet/events.cljs:95:20: warning: Shadowed var: cljs.core/uuid
projects/behave/src/cljs/behave/worksheet/events.cljs:95:25: warning: Shadowed var: cljs.core/name
projects/behave/src/cljs/behave/worksheet/events.cljs:203:47: warning: unused binding gv-uuid
projects/behave/src/cljs/behave/worksheet/events.cljs:285:14: warning: unused binding headers
projects/behave/src/cljs/behave/worksheet/events.cljs:451:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/events.cljs:515:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/events.cljs:725:15: warning: unused binding ds
projects/behave/src/cljs/behave/worksheet/subs.cljs:21:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/subs.cljs:25:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/subs.cljs:32:1: warning: Missing docstring.
projects/behave/src/cljs/behave/worksheet/subs.cljs:35:1: warning: Missing docstring.
projects/behave_cms/src/cljc/behave_cms/queries.cljc:3:1: warning: Missing docstring.
projects/behave_cms/src/cljs/behave_cms/subgroups/subs.cljs:107:32: warning: Shadowed var: cljs.core/name
projects/behave_cms/src/cljs/behave_cms/subgroups/subs.cljs:129:19: warning: Shadowed var: cljs.core/name
linting took 583ms, errors: 1, warnings: 63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants