Update FirePHP.class.php #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding error_reporting() as 2nd parameter (error_levels), when registering the errorhandler, results in not having to have a call to errorHandler() whenever PHP throwing an error, but only for those, that are activated. E_WARNINGs and E_NOTICEs can sum up very fast in hundreds to thousands of unnecessary calls to errorHandler(), just to have errorHandler() to decide not to throw an exception. Drawback of this version: if you change error_reporting after registerErrorHandler(), you have to call registerErrorHandler again, in order to get the new error_reporting into count. For backward compatibility, a new parameter ($use_error_reporting) is introduced, defaulting to false, providing the functions old behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding error_reporting() as 2nd parameter (error_levels), when registering the errorhandler, results in not having to have a call to errorHandler() whenever PHP throwing an error, but only for those, that are activated.
E_WARNINGs and E_NOTICEs can sum up very fast in hundreds to thousands of unnecessary calls to errorHandler(), just to have errorHandler() to decide not to throw an exception.
Drawback of this version: if you change error_reporting after registerErrorHandler(), you have to call registerErrorHandler again, in order to get the new error_reporting into count.
For backward compatibility, a new parameter ($use_error_reporting) is introduced, defaulting to false, providing the functions old behaviour