Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added health check #540

Merged
merged 1 commit into from
Jan 13, 2025
Merged

added health check #540

merged 1 commit into from
Jan 13, 2025

Conversation

mabels
Copy link
Contributor

@mabels mabels commented Jan 13, 2025

chore: double run presmoke:publish
chore: enable esm-cache
chore: fix esmd version

Summary by CodeRabbit

  • Chores

    • Updated .prettierignore to exclude specific directories
    • Modified package.json script to refine command matching
    • Updated Docker Compose configuration for improved service management
    • Enhanced smoke testing setup with version handling and logging
  • Infrastructure

    • Added volume mappings for registry and ESM services
    • Updated ESM service image to version v135_7
    • Implemented service readiness checks
  • Testing

    • Added setup script for version tracking in tests
    • Improved test configuration and logging

chore: double run presmoke:publish
chore: enable esm-cache
chore: fix esmd version
@mabels mabels merged commit b5ec886 into main Jan 13, 2025
1 of 2 checks passed
@mabels mabels deleted the mabels/docker-compose-healty branch January 13, 2025 12:15
Copy link

coderabbitai bot commented Jan 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several configuration and script modifications across multiple files. The changes focus on enhancing development and testing infrastructure, including updates to Prettier ignore patterns, Docker compose configuration, version handling in smoke tests, and minor script adjustments. The modifications aim to improve caching, service readiness checks, and version management for the project's testing and local development environment.

Changes

File Change Summary
.prettierignore Added ignore patterns for .esm-cache/, dist/, and coverage/ directories
package.json Modified "smoke" script regex from '/smoke:/' to '/^smoke:/'
smoke/docker-compose.yaml - Added volume mappings for registry and esm-sh services
- Updated esm-sh service image to v135_7
- Uncommented and modified wait-for-ready service with health checks
smoke/esm/it.sh Created setup.js with version handling functions gthis() and getVersion()
smoke/esm/src/index.test.ts Added logging for FP_VERSION and dynamic module import
smoke/esm/vite.config.ts Added setupFiles property pointing to ./setup.js
smoke/publish-local-registry.sh - Added ESM cache directory creation and permissions
- Exported PROJECT_BASE
- Modified Docker container startup with --wait
- Added npm unpublish step
tests/www/todo.html Reformatted drawInfo function's string assignment for readability

Sequence Diagram

sequenceDiagram
    participant Developer
    participant Docker
    participant Registry
    participant ESM Service
    
    Developer->>Docker: Start docker-compose
    Docker->>Registry: Mount volume
    Docker->>ESM Service: Mount volume
    Docker->>Docker: Start wait-for-ready service
    wait-for-ready->>Registry: Health check
    wait-for-ready->>ESM Service: Health check
    ESM Service-->>Developer: Service ready
Loading

The sequence diagram illustrates the enhanced Docker composition process, showing how services are started, volumes are mounted, and health checks are performed before the environment is considered ready.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a53f69a and d9f0e76.

📒 Files selected for processing (8)
  • .prettierignore (1 hunks)
  • package.json (1 hunks)
  • smoke/docker-compose.yaml (1 hunks)
  • smoke/esm/it.sh (1 hunks)
  • smoke/esm/src/index.test.ts (1 hunks)
  • smoke/esm/vite.config.ts (1 hunks)
  • smoke/publish-local-registry.sh (2 hunks)
  • tests/www/todo.html (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant