Skip to content

Fix overflow risk in strobeBlinkPin by updating parameter types and loop counter #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix overflow risk in strobeBlinkPin by updating parameter types and loop counter #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9001b6
fix(Firmata.cpp): use unsigned int and uint32_t in strobeBlinkPin to …
Chris0xdeadbeef Sep 23, 2025
d324e29
fix(Firmata.h): update strobeBlinkPin signature in header to use unsi…
Chris0xdeadbeef Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Firmata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,9 @@ void FirmataClass::setPinState(byte pin, int state)
* @param onInterval The number of milliseconds for the LED to be ON during each interval.
* @param offInterval The number of milliseconds for the LED to be OFF during each interval.
*/
void FirmataClass::strobeBlinkPin(byte pin, int count, int onInterval, int offInterval)
void FirmataClass::strobeBlinkPin(byte pin, unsigned int count, uint32_t onInterval, uint32_t offInterval)
{
byte i;
for (i = 0; i < count; i++) {
for (unsigned int i = 0; i < count; ++i) {
delay(offInterval);
digitalWrite(pin, HIGH);
delay(onInterval);
Expand Down
2 changes: 1 addition & 1 deletion Firmata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class FirmataClass
boolean blinkVersionDisabled;

/* private methods ------------------------------ */
void strobeBlinkPin(byte pin, int count, int onInterval, int offInterval);
void strobeBlinkPin(byte pin, unsigned int count, uint32_t onInterval, uint32_t offInterval);
friend void FirmataMarshaller::encodeByteStream (size_t bytec, uint8_t * bytev, size_t max_bytes) const;

/* callback functions */
Expand Down