Skip to content

Conversation

@bschwede
Copy link

related to Backlink for level 1 shared notes #5181

@bschwede bschwede changed the title fact label as link to shared note record fix #5181: fact label as link to shared note record Aug 24, 2025
@fisharebest
Copy link
Owner

We use Fact::label() in lots of places - including ones where we cannot have HTML markup. For example, in the <title></title> of some pages.

So I don't think that this is the correct solution to the issue.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.07%. Comparing base (9243191) to head (4934ad3).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/Fact.php 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5212      +/-   ##
============================================
- Coverage     35.08%   35.07%   -0.01%     
- Complexity    11203    11205       +2     
============================================
  Files          1161     1161              
  Lines         48486    48489       +3     
============================================
  Hits          17009    17009              
- Misses        31477    31480       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bschwede
Copy link
Author

I hadn't considered that.

Logic was moved to view fact and aligned with the display in view modules/notes/tab.
In addition, an edit icon was added for direct editing of the shared note text.

20250825_indi-notes-tab-shared-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants