BUGFIX: fix the bug that 'Element's will not scroll , while the second time u enter the component and click the 'Scroll' #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 21, 2016 12:40
…e, and no 'ScrollLink' would be 'active';
BUGFIX: fix the bug that links does't work when the last 2 or 3 elements are in a view;
…nts(on the bottom) are in a view;
|
Thank you! This fixed my problem! |
|
@fisshy I'm running into the same issue as described here and ISSUE https://github.com/fisshy/react-scroll/issues/120. Trying this PR resolves the issue. Can this be committed to main? So I dont have to use a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a page which contains some component using the
<ScrollLink>and the<Element>.<ScrollLink>and the relevant<Element>will scroll to the top.<ScrollLink>, the relevant<Element>doesn't scroll any more.Finally, I find out that
__containerElementdon't release while I unmount the component with the<ScrollLink>s and the<Element>s.There must be some better way to solve it, but it works for me.