-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollOffset #225
base: master
Are you sure you want to change the base?
Add scrollOffset #225
Conversation
Thanks for your PR. Why can't you use Offset? |
@fisshy I use offset, but in context of react-md top toolbar I need that new param to fix the scroll position generated by link click - in fact what I do is I cancel the offset like this:
Without scrollOffset param I was not able to fix the link to scroll to proper position. And I cant skip offset because then the highlight on scroll does not work. So I either needed variable to skip offset on scrollTo helper or add scrollOffset which would allow me to adjust the scrollTo. SInce I found an issue and a PR doing scrollOffset (which for some strange reason incuded also some other changes) - I made new PR with only the scrollOffset :) |
I have the the same problem as this |
I have the same problem, no clue why this is not merged |
+1 |
2 similar comments
+1 |
+1 |
I have the same problem, please separate spy offset and scroll offset |
Extra parameter allows tuning react-scroll for react-md sidebar / toolbar. Fixes #143