Fix to use offsetTop of absolute positioned container element #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had been suffered from scroll offset error, and I've finally found
scrollOffset
function inmodules/mixins/utils.js
is not working properly when container is absolute positioned element.I'm actually using react-custom-scrollbars to customize scrollbars, and it makes container element as an absolute positioned element. Because the computed
position
property of the container element is notrelative
butabsolute
, scroller changesscrollTop
to wrong position.I tried to change 26th line of
modules/mixins/utils.js
fromto
and all of my problem is gone.
** In addition, I also tested this changes for fixed positioned container element, it worked properly.