ScrollSnapMixin: an extension to achieve scroll-snap emulation with react-scroll #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure what this does or solves? |
|
Hi, @fisshy, have you seen an new example inside or links I that gave? |
|
What I was trying to achieve by these changes? I think that smooth scrolling can be used as is, but in conjunction with the snap-scrolling effect (which is optional) can be obtained good combination. Also please take a look at this post for more explanation. |
|
Alright, I'll go through the changes tonight and see how it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @fisshy,
please, take a look at this PR which brings new functionality to react-scroll. As said in title, my goal is to bring scroll-snap emulation to react-component to get the similar behavior like here or here (worked on wide screens only).
If you like it, please check it twice, because I'm just learning to programming;) Also, there is still some bugs, for example with touch events.