Handling of elements with dynamic height, for example accordions #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks cool. Haven't tried it myself yet, but will do and then most likely merge it. |
|
Ok, in few days. |
| } | ||
| var cords = element.getBoundingClientRect(); |
There was a problem hiding this comment.
We still have "if" statement in that case:
if(!element) { element = scroller.get(to); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with react-scroll. I used accordions in my project. If scroll the page, return to the top, and after that open an accordion then if you scroll manually again you will see that elements getting active in wrong places.
I familiarized with issues #49 and #59 but that problem does not solved. So I tried solve that issue myself.