Skip to content

refactor(cSDK): Add empty configuration file for examples with no configuration - #47

Merged
fivetran-rishabhghosh merged 2 commits into
mainfrom
satvik/RD-1241560-mandate-configuration
Aug 5, 2026
Merged

refactor(cSDK): Add empty configuration file for examples with no configuration#47
fivetran-rishabhghosh merged 2 commits into
mainfrom
satvik/RD-1241560-mandate-configuration

Conversation

@fivetran-satvikpatil

Copy link
Copy Markdown
Contributor

Description of Change

RD-1241560

Testing

Add an empty configuration file for examples with no configuration, as we are mandating a configuration file in the connector

@fivetran-satvikpatil fivetran-satvikpatil changed the title Add empty configuration file refactor(cSDK): Add empty configuration file for examples with no configuration Jul 16, 2026
@cla-assistant

cla-assistant Bot commented Jul 29, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Satvik Patil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fivetran-satvikpatil
fivetran-satvikpatil marked this pull request as ready for review August 5, 2026 07:41
Copilot AI lite review requested due to automatic review settings August 5, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes local debugging for example connectors by ensuring a configuration.json file exists (even when no configuration is required) and updating __main__ blocks to load that file and pass the resulting dict into connector.debug().

Changes:

  • Added empty configuration.json files ({}) for examples that do not require configuration.
  • Updated __main__ local-run blocks to json.load() the configuration.json and call connector.debug(configuration=configuration).
  • Added json import where needed to support configuration loading.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
owasp_api_vulns/connector.py Updates local debug comment to align with reading/passing configuration.json.
owasp_api_vulns/configuration.json Adds empty configuration object to satisfy mandated config file requirement.
odata_api/odata_version_4/connector.py Imports json and updates __main__ to load/pass configuration.json into connector.debug().
odata_api/odata_version_4/configuration.json Adds empty configuration object.
odata_api/odata_version_4_using_python_odata/connector.py Imports json and updates __main__ to load/pass configuration.json into connector.debug().
odata_api/odata_version_4_using_python_odata/configuration.json Adds empty configuration object.
odata_api/odata_version_2_using_pyodata/connector.py Imports json and updates __main__ to load/pass configuration.json into connector.debug().
odata_api/odata_version_2_using_pyodata/configuration.json Adds empty configuration object.

@fivetran-rishabhghosh
fivetran-rishabhghosh merged commit 515b319 into main Aug 5, 2026
3 of 4 checks passed
@fivetran-rishabhghosh
fivetran-rishabhghosh deleted the satvik/RD-1241560-mandate-configuration branch August 5, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants