refactor(cSDK): Add empty configuration file for examples with no configuration - #47
Merged
fivetran-rishabhghosh merged 2 commits intoAug 5, 2026
Merged
Conversation
fivetran-satvikpatil
requested review from
fivetran-meetmahna and
fivetran-sahilkhirwal
July 16, 2026 04:22
|
Satvik Patil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes local debugging for example connectors by ensuring a configuration.json file exists (even when no configuration is required) and updating __main__ blocks to load that file and pass the resulting dict into connector.debug().
Changes:
- Added empty
configuration.jsonfiles ({}) for examples that do not require configuration. - Updated
__main__local-run blocks tojson.load()theconfiguration.jsonand callconnector.debug(configuration=configuration). - Added
jsonimport where needed to support configuration loading.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| owasp_api_vulns/connector.py | Updates local debug comment to align with reading/passing configuration.json. |
| owasp_api_vulns/configuration.json | Adds empty configuration object to satisfy mandated config file requirement. |
| odata_api/odata_version_4/connector.py | Imports json and updates __main__ to load/pass configuration.json into connector.debug(). |
| odata_api/odata_version_4/configuration.json | Adds empty configuration object. |
| odata_api/odata_version_4_using_python_odata/connector.py | Imports json and updates __main__ to load/pass configuration.json into connector.debug(). |
| odata_api/odata_version_4_using_python_odata/configuration.json | Adds empty configuration object. |
| odata_api/odata_version_2_using_pyodata/connector.py | Imports json and updates __main__ to load/pass configuration.json into connector.debug(). |
| odata_api/odata_version_2_using_pyodata/configuration.json | Adds empty configuration object. |
fivetran-sahilkhirwal
approved these changes
Aug 5, 2026
fivetran-meetmahna
approved these changes
Aug 5, 2026
fivetran-rishabhghosh
deleted the
satvik/RD-1241560-mandate-configuration
branch
August 5, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
RD-1241560
Testing
Add an empty configuration file for examples with no configuration, as we are mandating a configuration file in the connector