-
Notifications
You must be signed in to change notification settings - Fork 38
Consolidate source + remove tests #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 16 commits
8108b6d
6adef62
fec0eae
ba87972
b5187bd
3d82ad5
8e495b7
490301b
61d71c0
b1ddae2
57f38ae
dbfdcbc
4439381
898092d
99f10bf
1445ad0
260edfe
6294378
96cc6d9
45239e9
f4b1752
edb31bd
80ad2e1
6c8e79d
7701e2e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: 'generate dbt docs' | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - labeled | ||
|
|
||
| jobs: | ||
| generate-docs: | ||
| if: github.event.label.name == 'docs:ready' | ||
| uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main | ||
| secrets: inherit | ||
| with: | ||
| # This needs to be kept a long list like this, and ': public' should not be included in the last var of the list. | ||
| schema_var_name: "salesforce_schema: 'public', salesforce_history_schema" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,73 @@ | ||
|
|
||
| target/ | ||
| # dbt | ||
| **/package-lock.yml | ||
| package-lock.yml | ||
| .dbt/ | ||
| dbt_modules/ | ||
| dbt_packages/ | ||
| logs/ | ||
| keyfile.json | ||
| profiles.yml | ||
| target/ | ||
| *.log | ||
|
|
||
| # IDE files | ||
| .idea/ | ||
| .vscode/ | ||
| *~ | ||
| *.swp | ||
| *.swo | ||
|
|
||
| # Jupyter Notebook | ||
| .ipynb_checkpoints | ||
|
|
||
| # OS generated files | ||
| **/.DS_Store | ||
| .DS_Store | ||
| develop/ | ||
| dbt_packages/ | ||
| env/ | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ._* | ||
| Thumbs.db | ||
| ehthumbs.db | ||
|
|
||
| # Python | ||
| *.egg | ||
| *.egg-info/ | ||
| *.py[cod] | ||
| *.so | ||
| *$py.class | ||
| .Python | ||
| __pycache__/ | ||
| build/ | ||
| develop-eggs/ | ||
| dist/ | ||
| downloads/ | ||
| eggs/ | ||
| .env | ||
| .installed.cfg | ||
| lib/ | ||
| lib64/ | ||
| MANIFEST | ||
| parts/ | ||
| sdist/ | ||
| var/ | ||
| wheels/ | ||
|
|
||
| # Secrets and credentials | ||
| .env.* | ||
| .secrets | ||
| credentials.json | ||
| service-account.json | ||
|
|
||
| # Temporary files | ||
| .cache/ | ||
| *.temp | ||
| *.tmp | ||
|
|
||
| # Virtual environments | ||
| .conda/ | ||
| .env | ||
| .venv | ||
| ENV/ | ||
| env/ | ||
| env.bak/ | ||
| venv/ | ||
| venv.bak/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,39 @@ | ||
| config-version: 2 | ||
| name: 'salesforce' | ||
| version: '1.3.0' | ||
| version: '2.0.0' | ||
| require-dbt-version: [">=1.3.0", "<2.0.0"] | ||
| models: | ||
| salesforce: | ||
| +materialized: table | ||
| intermediate: | ||
| +materialized: ephemeral | ||
|
Comment on lines
7
to
9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This config doesn't look right? There's no intermediate folder in this location.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This may be a FR for us to explore more in the future
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I noticed that too and noted it to make a FR later. Also all of the models get written to the target schema - would we want to explore changing that later as well?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @fivetran-joemarkiewicz should i create a FR here
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that would be great. I wouldn't want to change this just now, but we should in a future update.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created FR #68 for us to evaluate in a future update. |
||
|
|
||
| salesforce: | ||
| staging: | ||
| +materialized: table | ||
| tmp: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are no
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, removed this config as it's not being used. |
||
| +materialized: view | ||
| salesforce_history: | ||
| staging: | ||
| +materialized: table | ||
| tmp: | ||
| +materialized: view | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are no
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good call, removing as it's not used. |
||
| vars: | ||
| salesforce: | ||
| account: "{{ ref('stg_salesforce__account') }}" | ||
| opportunity: "{{ ref('stg_salesforce__opportunity') }}" | ||
| user: "{{ ref('stg_salesforce__user') }}" | ||
| user_role: "{{ ref('stg_salesforce__user_role') }}" | ||
| contact: "{{ ref('stg_salesforce__contact') }}" | ||
| lead: "{{ ref('stg_salesforce__lead') }}" | ||
| task: "{{ ref('stg_salesforce__task') }}" | ||
| event: "{{ ref('stg_salesforce__event') }}" | ||
| product_2: "{{ ref('stg_salesforce__product_2') }}" | ||
| order: "{{ ref('stg_salesforce__order') }}" | ||
| opportunity_line_item: "{{ ref('stg_salesforce__opportunity_line_item') }}" | ||
| account: "{{ source('salesforce', 'account') }}" | ||
| opportunity: "{{ source('salesforce', 'opportunity') }}" | ||
| user: "{{ source('salesforce', 'user') }}" | ||
| user_role: "{{ source('salesforce', 'user_role') }}" | ||
| contact: "{{ source('salesforce', 'contact') }}" | ||
| lead: "{{ source('salesforce', 'lead') }}" | ||
| task: "{{ source('salesforce', 'task') }}" | ||
| event: "{{ source('salesforce', 'event') }}" | ||
| product_2: "{{ source('salesforce', 'product_2') }}" | ||
| order: "{{ source('salesforce', 'order') }}" | ||
| opportunity_line_item: "{{ source('salesforce', 'opportunity_line_item') }}" | ||
|
|
||
| account_history: "{{ ref('stg_salesforce__account_history') }}" | ||
| contact_history: "{{ ref('stg_salesforce__contact_history') }}" | ||
| opportunity_history: "{{ ref('stg_salesforce__opportunity_history') }}" | ||
| account_history: "{{ source('salesforce', 'account_history') }}" | ||
| contact_history: "{{ source('salesforce', 'contact_history') }}" | ||
| opportunity_history: "{{ source('salesforce', 'opportunity_history') }}" | ||
|
fivetran-joemarkiewicz marked this conversation as resolved.
Outdated
|
||
|
|
||
| salesforce__account_pass_through_columns: [] | ||
|
fivetran-joemarkiewicz marked this conversation as resolved.
|
||
| salesforce__contact_pass_through_columns: [] | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.