-
Notifications
You must be signed in to change notification settings - Fork 38
Consolidate source + remove tests #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fivetran-joemarkiewicz
merged 25 commits into
main
from
MagicBot/consolidate-source-package
Aug 18, 2025
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8108b6d
Consolidate dbt source into transform
fivetran-catfritz 6adef62
Q2 FY26 Automatic Package Updates (#66)
fivetran-data-model-bot fec0eae
manual
fivetran-jamie ba87972
reorganize subfolders
fivetran-jamie b5187bd
cofnirm schemas are good
fivetran-jamie 3d82ad5
revert
fivetran-jamie 8e495b7
debugging
fivetran-jamie 490301b
try this
fivetran-jamie 61d71c0
Update generate-docs.yml
fivetran-catfritz b1ddae2
Generate dbt docs via GitHub Actions
github-actions[bot] 57f38ae
revert some stuff
fivetran-jamie dbfdcbc
Merge branch 'MagicBot/consolidate-source-package' of https://github.…
fivetran-jamie 4439381
Generate dbt docs via GitHub Actions
github-actions[bot] 898092d
readme
fivetran-jamie 99f10bf
readme again
fivetran-jamie 1445ad0
Apply suggestions from code review
fivetran-jamie 260edfe
Update dbt_project.yml
fivetran-joemarkiewicz 6294378
Update CHANGELOG.md
fivetran-joemarkiewicz 96cc6d9
Update CHANGELOG.md
fivetran-joemarkiewicz 45239e9
Update dbt_project.yml
fivetran-joemarkiewicz f4b1752
Update dbt_project.yml
fivetran-joemarkiewicz edb31bd
Update src_salesforce_history.yml
fivetran-joemarkiewicz 80ad2e1
Update src_salesforce.yml
fivetran-joemarkiewicz 6c8e79d
Generate dbt docs via GitHub Actions
github-actions[bot] 7701e2e
Update consistency_columns.sql
fivetran-joemarkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: 'generate dbt docs' | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - labeled | ||
|
|
||
| jobs: | ||
| generate-docs: | ||
| if: github.event.label.name == 'docs:ready' | ||
| uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main | ||
| secrets: inherit | ||
| with: | ||
| # This needs to be kept a long list like this, and ': public' should not be included in the last var of the list. | ||
| schema_var_name: "salesforce_schema: 'public', salesforce_history_schema" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,73 @@ | ||
|
|
||
| target/ | ||
| # dbt | ||
| **/package-lock.yml | ||
| package-lock.yml | ||
| .dbt/ | ||
| dbt_modules/ | ||
| dbt_packages/ | ||
| logs/ | ||
| keyfile.json | ||
| profiles.yml | ||
| target/ | ||
| *.log | ||
|
|
||
| # IDE files | ||
| .idea/ | ||
| .vscode/ | ||
| *~ | ||
| *.swp | ||
| *.swo | ||
|
|
||
| # Jupyter Notebook | ||
| .ipynb_checkpoints | ||
|
|
||
| # OS generated files | ||
| **/.DS_Store | ||
| .DS_Store | ||
| develop/ | ||
| dbt_packages/ | ||
| env/ | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ._* | ||
| Thumbs.db | ||
| ehthumbs.db | ||
|
|
||
| # Python | ||
| *.egg | ||
| *.egg-info/ | ||
| *.py[cod] | ||
| *.so | ||
| *$py.class | ||
| .Python | ||
| __pycache__/ | ||
| build/ | ||
| develop-eggs/ | ||
| dist/ | ||
| downloads/ | ||
| eggs/ | ||
| .env | ||
| .installed.cfg | ||
| lib/ | ||
| lib64/ | ||
| MANIFEST | ||
| parts/ | ||
| sdist/ | ||
| var/ | ||
| wheels/ | ||
|
|
||
| # Secrets and credentials | ||
| .env.* | ||
| .secrets | ||
| credentials.json | ||
| service-account.json | ||
|
|
||
| # Temporary files | ||
| .cache/ | ||
| *.temp | ||
| *.tmp | ||
|
|
||
| # Virtual environments | ||
| .conda/ | ||
| .env | ||
| .venv | ||
| ENV/ | ||
| env/ | ||
| env.bak/ | ||
| venv/ | ||
| venv.bak/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config doesn't look right? There's no intermediate folder in this location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a FR for us to explore more in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I noticed that too and noted it to make a FR later. Also all of the models get written to the target schema - would we want to explore changing that later as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz should i create a FR here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be great. I wouldn't want to change this just now, but we should in a future update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created FR #68 for us to evaluate in a future update.