Update/add data model questions#78
Merged
Merged
Conversation
fivetran-joemarkiewicz
requested changes
Oct 24, 2025
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Contributor
There was a problem hiding this comment.
The updates look good. I have one comment to also update the table descriptions as well. The technical terminology will still be present in the yml docs.
| | [salesforce__account_daily_history](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__account_daily_history) | Each record is a daily record in an account, starting with its first active date and updating up toward either the current date (if still active) or its last active date. | No | ||
| | [salesforce__contact_daily_history](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__contact_daily_history) | Each record is a daily record in an contact, starting with its first active date and updating up toward either the current date (if still active) or its last active date. | No | ||
| | [salesforce__opportunity_daily_history](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__opportunity_daily_history) | Each record is a daily record in an opportunity, starting with its first active date and updating up toward either the current date (if still active) or its last active date. | No | ||
| | [salesforce__manager_performance](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__manager_performance) |Each record represents a manager, enriched with data about their team's pipeline, bookings, losses, and win percentages.<br><br>**Example Analytics Questions:**<br>• What is the correlation between a manager's team size and their total bookings performance this quarter?<br>• Which managers are struggling with pipeline conversion and would benefit from additional coaching or resources? | Yes |
Contributor
There was a problem hiding this comment.
Let's also update the description of the model. The description is geared towards very technical understanding of the table. However, let's position it to highlight how you can use it. For example in this case we could rewrite to something like the following:
Suggested change
| | [salesforce__manager_performance](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__manager_performance) |Each record represents a manager, enriched with data about their team's pipeline, bookings, losses, and win percentages.<br><br>**Example Analytics Questions:**<br>• What is the correlation between a manager's team size and their total bookings performance this quarter?<br>• Which managers are struggling with pipeline conversion and would benefit from additional coaching or resources? | Yes | |
| | [salesforce__manager_performance](https://fivetran.github.io/dbt_salesforce/#!/model/model.salesforce.salesforce__manager_performance) |This table provides performance metrics by manager, showing team level pipeline, bookings, losses, and win rates.<br><br>**Example Analytics Questions:**<br>• What is the correlation between a manager's team size and their total bookings performance this quarter?<br>• Which managers are struggling with pipeline conversion and would benefit from additional coaching or resources? | Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog