Skip to content

bugfix/checkout_session_column_name#144

Merged
fivetran-savage merged 4 commits into
mainfrom
bugfix/checkout_session_column_name
Mar 31, 2026
Merged

bugfix/checkout_session_column_name#144
fivetran-savage merged 4 commits into
mainfrom
bugfix/checkout_session_column_name

Conversation

@fivetran-savage

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 1.6.1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Changes checkout_session_id to checkout_session in subscription_discount source

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Mar 31, 2026
@fivetran-savage fivetran-savage self-assigned this Mar 31, 2026

@fivetran-avinash fivetran-avinash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage Two things before approval!

Comment thread macros/staging/get_subscription_discount_columns.sql
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated

@fivetran-avinash fivetran-avinash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage Noticed one more tweak but good to release afterward.

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
@fivetran-savage
fivetran-savage merged commit 979d10b into main Mar 31, 2026
9 checks passed
@fivetran-savage
fivetran-savage deleted the bugfix/checkout_session_column_name branch March 31, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants