Skip to content

bugfix/restore_stripe_mrr_history#153

Merged
fivetran-savage merged 10 commits into
mainfrom
bugfix/restore_stripe_mrr_history
Jul 21, 2026
Merged

bugfix/restore_stripe_mrr_history#153
fivetran-savage merged 10 commits into
mainfrom
bugfix/restore_stripe_mrr_history

Conversation

@fivetran-savage

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 1.9.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Anchor's stripe__subscription_item_mrr_report date spine to the subscription_item.created_at date and gets historical amounts from invoice_line_item as subscription_item. This report now requires the invoice_line_item table.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Jul 15, 2026
@fivetran-savage fivetran-savage self-assigned this Jul 15, 2026

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @fivetran-savage. A few change requests before approving.

Comment thread models/stripe__subscription_item_mrr_report.sql Outdated
Comment thread CHANGELOG.md Outdated
Comment thread integration_tests/dbt_project.yml
Comment thread models/stripe__subscription_item_mrr_report.sql Outdated
Comment thread models/stripe__subscription_item_mrr_report.sql
Comment thread DECISIONLOG.md Outdated
Comment thread DECISIONLOG.md Outdated
Comment thread models/stripe__subscription_item_mrr_report.sql Outdated
Comment thread models/stripe__subscription_item_mrr_report.sql
@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 17, 2026
@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 17, 2026

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few doc requests before merging

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the analyses/README.md we mention subscriptions must be enabled. We need to also add that invoices need to be enabled as well.

Comment thread models/stripe.yml Outdated
Comment on lines 995 to 996

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also clarify here that for this field historical months use current price with historical quantity.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also note that setting this to False will disable the subscription_item_mrr report as well.

@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 21, 2026
@fivetran-savage
fivetran-savage merged commit 5159f92 into main Jul 21, 2026
9 checks passed
@fivetran-savage
fivetran-savage deleted the bugfix/restore_stripe_mrr_history branch July 21, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants