Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace std partition_point #112

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c9fe47e
perf: replace partition_point in block index and disjoint level
marvin-j97 Mar 6, 2025
69c50e8
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 6, 2025
70e81d9
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 6, 2025
8db7d04
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 6, 2025
941c3ad
Merge remote-tracking branch 'origin/perf/replace-partition-point' in…
marvin-j97 Mar 6, 2025
f1e460e
comment
marvin-j97 Mar 6, 2025
2f61faf
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 6, 2025
0466df8
benchmark custom partition_point
marvin-j97 Mar 7, 2025
ffeeea5
perf: replace partition_point everywhere
marvin-j97 Mar 7, 2025
26eb2f3
refactor
marvin-j97 Mar 8, 2025
d390753
Merge remote-tracking branch 'origin/main' into perf/replace-partitio…
marvin-j97 Mar 8, 2025
2d8686e
perf: get_unchecked in partition_point
marvin-j97 Mar 11, 2025
4982254
test: added partition_point fuzz test
marvin-j97 Mar 11, 2025
2ab305d
doc
marvin-j97 Mar 11, 2025
65264ef
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 12, 2025
0dca39e
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 15, 2025
455c94f
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 21, 2025
258d485
Update binary_search.rs
marvin-j97 Mar 23, 2025
bd2ff04
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 24, 2025
b7dfce3
Merge branch 'main' into perf/replace-partition-point
marvin-j97 Mar 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor
marvin-j97 committed Mar 8, 2025
commit 26eb2f36e6b00930f11a9c373c65351d46597ac3
1 change: 0 additions & 1 deletion src/segment/value_block.rs
Original file line number Diff line number Diff line change
@@ -57,7 +57,6 @@ pub type ValueBlock = Block<InternalValue>;
impl ValueBlock {
#[must_use]
pub fn get_latest(&self, key: &[u8]) -> Option<&InternalValue> {
// TODO: bench hand rolled binary search
let idx = partition_point(&self.items, |item| &*item.key.user_key < key);

self.items
1 change: 0 additions & 1 deletion src/segment/value_block_consumer.rs
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@ impl ValueBlockConsumer {
Self::with_bounds(inner, None, None)
}

// TODO: PERF: benchmark replacing partition_point
#[must_use]
pub fn with_bounds(
inner: Arc<ValueBlock>,