Skip to content

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 10, 2024

No description provided.

@jstucke jstucke self-assigned this Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (5c24429) to head (47b92ed).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   91.66%   91.97%   +0.30%     
==========================================
  Files         374      372       -2     
  Lines       21052    21037      -15     
==========================================
+ Hits        19298    19349      +51     
+ Misses       1754     1688      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke force-pushed the custom-loading-animation branch from 1c76ee9 to 5e07e49 Compare January 9, 2025 10:20
@jstucke jstucke force-pushed the custom-loading-animation branch from 5e07e49 to 167f872 Compare January 17, 2025 15:20
@jstucke jstucke force-pushed the custom-loading-animation branch from 167f872 to 4181493 Compare June 4, 2025 11:46
@jstucke jstucke marked this pull request as ready for review June 4, 2025 15:24
@jstucke jstucke requested a review from dorpvom June 4, 2025 15:24
<p>Upload in progress...</p>
</div>
<script>
loadLoadingAnimation('loading-gif');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be loading-img right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are absolutely right -> changed

</button>

</form>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it redundant here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there was still the <img ...> element in the code, but since starting the search loads the next page directly, it was not actually visible here.

@jstucke jstucke force-pushed the custom-loading-animation branch from 4181493 to 47b92ed Compare December 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants