Skip to content

Fix: Resolve JSONB cast error in get_latest_comments method #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willardy101-ank wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Resolve JSONB cast error in get_latest_comments method #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/storage/db_interface_frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from pathlib import Path
from typing import Any, NamedTuple, Optional

from sqlalchemy import Column, Integer, cast, func, or_, select
from sqlalchemy import Column, func, or_, select, text

from helperFunctions.data_conversion import get_value_of_first_key
from helperFunctions.tag import TagColor
Expand Down Expand Up @@ -168,8 +168,11 @@ def get_other_versions_of_firmware(self, firmware: Firmware) -> list[tuple[str,

def get_latest_comments(self, limit=10):
with self.get_read_only_session() as session:
subquery = select(FileObjectEntry.uid, func.jsonb_array_elements(FileObjectEntry.comments)).subquery()
query = select(subquery).order_by(cast(subquery.c.jsonb_array_elements.op('->>')('time'), Integer).desc())
# Create subquery with explicit column label
comment_col = func.jsonb_array_elements(FileObjectEntry.comments).label('comment_data')
subquery = select(FileObjectEntry.uid, comment_col).subquery()
# Use the labeled column with -> operator
query = select(subquery).order_by(text("comment_data -> 'time' DESC"))
return [{'uid': uid, **comment_dict} for uid, comment_dict in session.execute(query.limit(limit))]

# --- generic search ---
Expand Down
Loading