Skip to content

Range attributes #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

Range attributes #178

merged 1 commit into from
Dec 21, 2023

Conversation

johannesodland
Copy link
Contributor

@johannesodland johannesodland commented Nov 25, 2023 •
edited
Loading

Adds support for getting and setting rangeStart and rangeEnd on Animation.

  • Adds support for the 'normal' value
  • Adds getters and setters for rangeStart and rangeEnd
    • setters are limited to ViewTimelines for now, as the existing implementation is limited to ViewTimelines
  • Uses CSSNumericValue.parse() to parse string values for range start and range end.
    • This adds support for math functions such as calc(100% - 20px).

@johannesodland johannesodland mentioned this pull request Nov 25, 2023
Closed
@johannesodland johannesodland marked this pull request as ready for review December 21, 2023 18:07
@flackr flackr merged commit 0803f77 into flackr:master Dec 21, 2023
This was referenced Dec 23, 2023
Merged
Closed
@johannesodland johannesodland deleted the range-attributes branch December 28, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannesodland @flackr