Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on subject size change #199

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

johannesodland
Copy link
Contributor

@johannesodland johannesodland commented Jan 7, 2024

Update timelines and animations on subject resize.

This PR was created to pass /scroll-animations/view-timelines/view-timeline-subject-size-changes.html

The test is already passing as we are observing the direct children of source.

I still think it would be useful to observe the subject directly. Preferably this feature could be opted into by users of the polyfill.

@johannesodland johannesodland force-pushed the update-on-subject-size-change branch from 90090f4 to 80c3e2d Compare February 3, 2024 13:31
@johannesodland johannesodland marked this pull request as ready for review February 4, 2024 09:18
@flackr flackr merged commit 32b7ea4 into flackr:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants