Account for insets when comparing size of subject to size of scrollport/view progress visibility range #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesodland
force-pushed
the
account-for-insets-when-comparing-to-scrollport
branch
from
b227c0c to
7ce2523
Compare
…rt/view progress range
johannesodland
force-pushed
the
account-for-insets-when-comparing-to-scrollport
branch
from
7ce2523 to
73e0223
Compare
bramus
requested changes
Jan 26, 2024
Co-authored-by: Bramus <[email protected]>
bramus
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should account for insets when evaluating
targetIsTallerThanContainer.Currently the range is slightly off when the subject is close in size to the inset adjusted scrollport.