Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll-animation.html start and current time subtests #230

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix scroll-animation.html start and current time subtests #230

merged 1 commit into from
Feb 6, 2024

Conversation

johannesodland
Copy link
Contributor

Schedule a micro task for updatingInternal() after adding an animation. If updateInternal() runs in the same task then animation.currentTime will be set by the time animation.play() returns.

Delaying this function revealed two other issues that needed to be fixed:

  • Infinite durations needed to be validated in getTimingHandler.
  • holdTime was set to unresolved in tickAnimation, flipping the playState from 'finished' to 'running'.

@flackr flackr merged commit 901e926 into flackr:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannesodland @flackr