Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out error when failing to calculate the rangeStart and rangeEnd #233

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Print out error when failing to calculate the rangeStart and rangeEnd #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/proxy-animation.js
View file
Original file line number Diff line number Diff line change
@@ -889,7 +889,7 @@ function autoAlignStartTime(details) {
// In the case of view timelines, it requires a calculation based on the proportion of the cover range.
try {
startOffset = CSS.percent(fractionalStartDelay(details) * 100);
} catch {
} catch (e) {
// TODO: Validate supported values for range start, to avoid exceptions when resolving the values.

// Range start is invalid, falling back to default value
@@ -902,7 +902,7 @@ function autoAlignStartTime(details) {
// In the case of view timelines, it requires a calculation based on the proportion of the cover range.
try {
endOffset = CSS.percent((1 - fractionalEndDelay(details)) * 100);
} catch {
} catch (e) {
// TODO: Validate supported values for range end, to avoid exceptions when resolving the values.

// Range start is invalid, falling back to default value