Skip to content

Conversation

@MARD1NO
Copy link
Collaborator

@MARD1NO MARD1NO commented Mar 18, 2025

PR Category

Type of Change

Description

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@MARD1NO MARD1NO marked this pull request as ready for review March 18, 2025 11:59
@MARD1NO MARD1NO requested a review from StrongSpoon March 18, 2025 11:59
@tongxin
Copy link
Contributor

tongxin commented Mar 24, 2025

Please fix coverage test and we'll merge.

Copy link
Collaborator

@Bowen12992 Bowen12992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI code coverage

@MARD1NO
Copy link
Collaborator Author

MARD1NO commented Mar 24, 2025

Please fix coverage test and we'll merge.

image
The coverage test failed since CI cannot test the backward

@tongxin
Copy link
Contributor

tongxin commented Mar 24, 2025

Please fix coverage test and we'll merge.

image The coverage test failed since CI cannot test the backward

I got it. How likely are we going to support backward coverage? @Bowen12992

Copy link
Contributor

@tongxin tongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bowen12992 Bowen12992 merged commit 0dc5cb3 into master Mar 24, 2025
8 of 9 checks passed
@Bowen12992 Bowen12992 deleted the add_gelu_and_mul_grad branch March 24, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants