Skip to content

Manage xpc in Buckeitng Mode#55

Open
ABTastyAdel wants to merge 5 commits into5.0.0-betafrom
xpcBucketing
Open

Manage xpc in Buckeitng Mode#55
ABTastyAdel wants to merge 5 commits into5.0.0-betafrom
xpcBucketing

Conversation

@ABTastyAdel
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@ABTastyAdel ABTastyAdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recheck this part

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors visitor cache lookup and authentication behavior, exposes errors for external use, and bumps the SDK version. Also includes storyboard layout tweaks and a temporary UI override.

  • Refactors visitor cache lookup with new helper methods and error handling; moves lookup invocation from Flagship to FSVisitor.
  • Adds cache existence checks and new db method; makes FlagshipError public; bumps version to 5.1.0-beta.1.
  • Temporarily forces BUCKETING mode in the example app; comments out connectivity helper.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
iOS Example/QApp/FSConfigViewController.swift Temporarily forces mode to BUCKETING in onClikcStart.
iOS Example/QApp/Base.lproj/Main.storyboard Frame/tooling metadata adjustments; minor text change.
FlagShip/Source/Tools/FlagShipVersion.swift Bumps internal version string.
FlagShip/Source/Tools/FSTools.swift Comments out isConnexionAvailable implementation.
FlagShip/Source/Strategy/FSDefaultStrategy.swift Removes mode guard for auth, adds cache lookup helpers, and new isVistorCacheExist method.
FlagShip/Source/Storage/FSVisitorDbMgt.swift Adds isVisitorExist query with SQLite parameter binding.
FlagShip/Source/Logger/FSError.swift Exposes FlagshipError as public.
FlagShip/Source/Core/Flagship.swift Removes immediate visitor cache lookup on visitor creation.
FlagShip/Source/Core/FSVisitor.swift Invokes visitor lookup before synchronize; caches anonymous visitor if missing.
FlagShip/Source/Core/FSVisitor+Reconcilliation.swift Removes mode guard for (un)authenticate; adds copy() and comments.
FlagShip/Source/Cache/FSDefaultCache.swift Implements isVisitorCacheExist via DB method.
FlagShip/Source/Cache/FSCacheManager.swift Adds isVisitorCacheExist API; changes lookupVisitorCache error type and handling.
FlagShip/Flagship.xcodeproj/project.pbxproj Updates marketing version.
FlagShip.podspec Updates pod version.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 55.66038% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.00%. Comparing base (def828a) to head (d2c2774).
⚠️ Report is 2 commits behind head on 5.0.0-beta.

Files with missing lines Patch % Lines
...agShip/Source/Core/FSVisitor+Reconcilliation.swift 0.00% 23 Missing ⚠️
FlagShip/Source/Strategy/FSDefaultStrategy.swift 78.37% 8 Missing ⚠️
FlagShip/Source/Cache/FSCacheManager.swift 50.00% 7 Missing ⚠️
FlagShip/Source/Storage/FSVisitorDbMgt.swift 75.00% 5 Missing ⚠️
FlagShip/Source/Core/FSVisitor.swift 55.55% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           5.0.0-beta      #55      +/-   ##
==============================================
- Coverage       82.40%   76.00%   -6.40%     
==============================================
  Files              79       79              
  Lines            4626     4685      +59     
==============================================
- Hits             3812     3561     -251     
- Misses            814     1124     +310     
Files with missing lines Coverage Δ
FlagShip/Source/Cache/FSDefaultCache.swift 86.48% <100.00%> (+0.77%) ⬆️
FlagShip/Source/Core/Flagship.swift 93.50% <100.00%> (-0.25%) ⬇️
FlagShip/Source/Logger/FSError.swift 100.00% <ø> (ø)
FlagShip/Source/Tools/FSTools.swift 97.05% <ø> (+12.44%) ⬆️
FlagShip/Source/Core/FSVisitor.swift 83.68% <55.55%> (-1.92%) ⬇️
FlagShip/Source/Storage/FSVisitorDbMgt.swift 85.71% <75.00%> (-7.39%) ⬇️
FlagShip/Source/Cache/FSCacheManager.swift 82.95% <50.00%> (-8.08%) ⬇️
FlagShip/Source/Strategy/FSDefaultStrategy.swift 84.86% <78.37%> (-1.50%) ⬇️
...agShip/Source/Core/FSVisitor+Reconcilliation.swift 39.47% <0.00%> (-60.53%) ⬇️

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f002b9a...d2c2774. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@ABTastyAdel ABTastyAdel changed the title clean fucntion Manage xpc in Buckeitng Mode Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants