Conversation
ABTastyAdel
left a comment
There was a problem hiding this comment.
Recheck this part
There was a problem hiding this comment.
Pull Request Overview
Refactors visitor cache lookup and authentication behavior, exposes errors for external use, and bumps the SDK version. Also includes storyboard layout tweaks and a temporary UI override.
- Refactors visitor cache lookup with new helper methods and error handling; moves lookup invocation from Flagship to FSVisitor.
- Adds cache existence checks and new db method; makes FlagshipError public; bumps version to 5.1.0-beta.1.
- Temporarily forces BUCKETING mode in the example app; comments out connectivity helper.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| iOS Example/QApp/FSConfigViewController.swift | Temporarily forces mode to BUCKETING in onClikcStart. |
| iOS Example/QApp/Base.lproj/Main.storyboard | Frame/tooling metadata adjustments; minor text change. |
| FlagShip/Source/Tools/FlagShipVersion.swift | Bumps internal version string. |
| FlagShip/Source/Tools/FSTools.swift | Comments out isConnexionAvailable implementation. |
| FlagShip/Source/Strategy/FSDefaultStrategy.swift | Removes mode guard for auth, adds cache lookup helpers, and new isVistorCacheExist method. |
| FlagShip/Source/Storage/FSVisitorDbMgt.swift | Adds isVisitorExist query with SQLite parameter binding. |
| FlagShip/Source/Logger/FSError.swift | Exposes FlagshipError as public. |
| FlagShip/Source/Core/Flagship.swift | Removes immediate visitor cache lookup on visitor creation. |
| FlagShip/Source/Core/FSVisitor.swift | Invokes visitor lookup before synchronize; caches anonymous visitor if missing. |
| FlagShip/Source/Core/FSVisitor+Reconcilliation.swift | Removes mode guard for (un)authenticate; adds copy() and comments. |
| FlagShip/Source/Cache/FSDefaultCache.swift | Implements isVisitorCacheExist via DB method. |
| FlagShip/Source/Cache/FSCacheManager.swift | Adds isVisitorCacheExist API; changes lookupVisitorCache error type and handling. |
| FlagShip/Flagship.xcodeproj/project.pbxproj | Updates marketing version. |
| FlagShip.podspec | Updates pod version. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 5.0.0-beta #55 +/- ##
==============================================
- Coverage 82.40% 76.00% -6.40%
==============================================
Files 79 79
Lines 4626 4685 +59
==============================================
- Hits 3812 3561 -251
- Misses 814 1124 +310
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



No description provided.