Skip to content

Q2#84

Merged
Heihokon merged 1 commit intomainfrom
q2
May 22, 2025
Merged

Q2#84
Heihokon merged 1 commit intomainfrom
q2

Conversation

@Heihokon
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 99.74811% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.94%. Comparing base (cb3fe1e) to head (39152bf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Api/BatchingCachingStrategyAbstract.php 98.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
- Coverage     99.97%   99.94%   -0.03%     
- Complexity     1131     1168      +37     
============================================
  Files            56       56              
  Lines          3791     3743      -48     
============================================
- Hits           3790     3741      -49     
- Misses            1        2       +1     
Flag Coverage Δ
unittests 99.94% <99.74%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Heihokon Heihokon force-pushed the q2 branch 5 times, most recently from f6208b1 to 17e549f Compare May 21, 2025 19:12
Refactor FlagshipConstant.php to add XPC_BUCKETING_WARNING constant

Add VisitorCacheStatus enum

refactor: Add arraysAreEqual method to Helper trait

refactor: Add abstract method to update context key-value pair

refactor: Update DefaultStrategy to set hasContextBeenUpdated flag

refactor: Update VisitorAbstract to include hasContextBeenUpdated flag

refactor: Add HelperTest for Helper trait

refactor: Update BucketingManager to send context only if it has been updated

refactor: Set hasContextBeenUpdated flag in DefaultStrategy's updateContext and updateContextCollection methods

refactor: Update BucketingManagerTest to improve test coverage

refactor: Remove unnecessary code in DefaultStrategy's updateContext and updateContextCollection methods

refactor: Improve error messages in FlagshipConstant.php

refactor: Update DefaultStrategy.php to improve flag activation logic

refactor: Improve flag activation logic in DefaultStrategyTest.php

refactor: Improve error handling and troubleshooting in BucketingManager.php

Refactor VisitorAbstract to add visitorCacheStatus property and getter/setter methods

Refactor StrategyAbstract to update visitor cache status and add context key-value method

Refactor DefaultStrategy to log XPC warning when visitor cache is not implemented

Refactor code to improve visitor cache functionality and add XPC warning logging

Refactor VisitorCacheStatus enum to rename VISITOR_ID_CACHE_ONLY to VISITOR_ID_CACHE_WITH_ANONYMOUS_ID_CACHE

Refactor StrategyAbstract to update visitor cache status and fix visitor cache lookup bug

Refactor VisitorDelegate to call lookupVisitor() method before fetching flags

Refactor DefaultStrategyTest to update visitor cache status and fix visitor cache lookup bug

Refactor StrategyAbstract to remove unused method updateContextKeyValue()

refactor: Add abstract method updateContextKeyValue to StrategyAbstract

refactor: Update LogTrait to use mixed type for responseHeader, responseBody, and responseStatus

refactor: Add allocation check for variations in BucketingManager

test: Enhance DefaultStrategyTest with additional assertions and visitor cache checks

refactor: Update BatchingCachingStrategyAbstract.php to improve code readability and maintainability

refactor: Update BatchingCachingStrategyAbstract.php to send activate hits in batches

refactor: Add constant for maximum activate hits per batch in FlagshipConstant.php

refactor: Update BatchingCachingStrategyAbstract.php to send activate hits in batches
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Heihokon Heihokon merged commit b2ee597 into main May 22, 2025
3 of 6 checks passed
@Heihokon Heihokon deleted the q2 branch May 22, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant