Refactor: Modernize PHP SDK with enhanced type safety and new DTO models#89
Merged
Refactor: Modernize PHP SDK with enhanced type safety and new DTO models#89
Conversation
New Features: - Introduced comprehensive DTO models for campaigns, variations, targeting, and troubleshooting - Added Types trait for centralized type definitions with PHPStan-level type safety - Implemented ContainerException for better error handling - Enhanced visitor strategies with context updates and troubleshooting support Improvements: - Removed deprecated FlagshipLogManager8 class - Updated ModificationsDTO value type from mixed to array for consistency - Refactored ContainerInterface with improved type specifications - Updated HttpClient with better error handling and type safety - Enhanced MurmurHash, Curl, and logging interfaces for clarity - Added utility methods in Helper trait for array operations - Improved flag activation with flag key inclusion in hits - Updated return types across DecisionManagerAbstract and various interfaces Testing: - Refactored test suite to use BaseTestCase for consistency - Added comprehensive unit tests for new DTO classes - Enhanced test coverage for FlagshipLogManager, HttpClient, and strategy classes - Improved test readability with standardized formatting and assertions Configuration: - Updated PHPStan configuration with new rules and future compatibility - Enhanced composer.json with additional static analysis tools - Refined phpstan.neon and added phpstan-future.neon
Heihokon
force-pushed
the
fix-deprecated-log
branch
from
9bcf680 to
13d9d62
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features:
Improvements:
Testing:
Configuration: